Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 878763003: undo zturner visualc compiler workaround (Closed)

Created:
5 years, 11 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

undo zturner visualc compiler workaround An optimization on the compiler. https://connect.microsoft.com/VisualStudio/feedback/details/800200/preprocessing-broken-in-vs2013 also see comment #56 on the bug below BUG=288948 Committed: https://crrev.com/0fa034a6a15155bae958f9859fae38bb747185d2 Cr-Commit-Position: refs/heads/master@{#313304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M ipc/ipc_message_macros.h View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
cpu_(ooo_6.6-7.5)
ptal
5 years, 11 months ago (2015-01-27 03:20:18 UTC) #2
scottmg
lgtm
5 years, 11 months ago (2015-01-27 03:52:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878763003/1
5 years, 11 months ago (2015-01-27 17:23:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 18:05:19 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 18:06:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fa034a6a15155bae958f9859fae38bb747185d2
Cr-Commit-Position: refs/heads/master@{#313304}

Powered by Google App Engine
This is Rietveld 408576698