Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 878763002: Revert of Instrumenting opening password database to find jank (Closed)

Created:
5 years, 11 months ago by vadimt
Modified:
5 years, 11 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, pavely
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Instrumenting opening password database to find jank (patchset #1 id:1 of https://codereview.chromium.org/807263003/) Reason for revert: Undoing profiler instrumentations since the jank is fixed. Original issue's description: > Instrumenting opening password database to find jank. > > This database opening happens in UI thread. Checking what jankiness this causes. > > Background: one of jankiness investigations (crbug.com/426272) came to a conclusion that the jank is actually caused by this issue. Instrumenting to get the numbers. > > BUG=138903 > > Committed: https://crrev.com/42466460ec1a5c0f2953d13e57d0d290cb38ca21 > Cr-Commit-Position: refs/heads/master@{#308702} TBR=isherman@chromium.org BUG=138903 Committed: https://crrev.com/d6300bd0250c5b55a4b8021e930a216ee959b5cd Cr-Commit-Position: refs/heads/master@{#313168}

Patch Set 1 #

Patch Set 2 : resolving conflicts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -10 lines) Patch
M components/password_manager/core/browser/login_database.cc View 1 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
vadimt
Created Revert of Instrumenting opening password database to find jank
5 years, 11 months ago (2015-01-26 21:54:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878763002/1
5 years, 11 months ago (2015-01-26 21:55:53 UTC) #2
commit-bot: I haz the power
Failed to apply patch for components/password_manager/core/browser/login_database.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 11 months ago (2015-01-26 21:56:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878763002/40001
5 years, 11 months ago (2015-01-26 22:40:20 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 11 months ago (2015-01-26 23:36:17 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d6300bd0250c5b55a4b8021e930a216ee959b5cd Cr-Commit-Position: refs/heads/master@{#313168}
5 years, 11 months ago (2015-01-26 23:38:32 UTC) #9
Ilya Sherman
LGTM. Thanks for coming back around to this cleanup task :)
5 years, 11 months ago (2015-01-26 23:47:56 UTC) #10
vadimt
5 years, 11 months ago (2015-01-26 23:48:56 UTC) #11
Message was sent while issue was closed.
My pleasure :)

On Mon, Jan 26, 2015 at 3:47 PM, <isherman@chromium.org> wrote:

> LGTM.  Thanks for coming back around to this cleanup task :)
>
> https://codereview.chromium.org/878763002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698