Implement CredentialItemView and tests for the Mac account chooser.

chrome/browser/ui/cocoa/passwords/credential_item_view.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_PASSWORDS_CREDENTIAL_ITEM_VIEW_H_
+#define CHROME_BROWSER_UI_COCOA_PASSWORDS_CREDENTIAL_ITEM_VIEW_H_
+
+#import <Cocoa/Cocoa.h>
+
+#import "base/mac/scoped_nsobject.h"
+#include "components/autofill/core/common/password_form.h"
+#include "components/password_manager/content/common/credential_manager_types.h"
+
+class GURL;
+
+@class CredentialItemView;

[groby-ooo-7-16, 2015/03/03 17:34:33]

We usually combine class/@class forward decls into one list (alphabetized)

[dconnelly, 2015/03/04 12:30:54]

Done.

+
+// Handles user interaction with and image fetching for a CredentialItemView.
+@protocol CredentialItemDelegate<NSObject>
+
+// Retrieves the image located at |avatarURL| and updates |view| by calling
+// [CredentialItemView updateAvatar:] if successful.
+- (void)fetchAvatar:(const GURL&)avatarURL forView:(CredentialItemView*)view;
+
+@end
+
+// A view to show a single account credential.
+@interface CredentialItemView : NSView {
+  autofill::PasswordForm passwordForm_;
+  password_manager::CredentialType credentialType_;
+  base::scoped_nsobject<NSTextField> nameLabel_;

[groby-ooo-7-16, 2015/03/03 17:34:33]

Do we want to refcount here? (I know, I contradict myself on the id<> further
down - it's a general question which items actually should be refcounted/owned)

[dconnelly, 2015/03/04 12:30:54]

I've removed the scoping to match the other reviews you've done for me, but in
general this makes me nervous. It relies on |subviews| maintaining references to
these objects, and if |subviews| is changed, they're all blown away and these
pointers will be invalid. I don't see the problem with some extra
defensive-programming refs.

[groby-ooo-7-16, 2015/03/04 16:17:59]

Well, they're not entirely free :) I don't have a strong preference either way,
though. I just wanted to make sure I understand the ownership reasoning.

+  base::scoped_nsobject<NSTextField> usernameLabel_;
+  base::scoped_nsobject<NSImageView> avatarView_;
+  id<CredentialItemDelegate> delegate_;

[groby-ooo-7-16, 2015/03/03 17:34:33]

Do you want scoped_nsprotocol here? (I.e. do we want to refcount?)

[dconnelly, 2015/03/04 12:30:54]

ManagePasswordsBubbleAccountChooserViewController, which you already reviewed,
both uses a CredentialItemView and is its delegate, so refcounting here would
lead to a reference cycle. In Bling we use WeakNSObject/WeakNSProtocol to store
auto-nilling references to delegates, but it's not available here in Mac-land.

[groby-ooo-7-16, 2015/03/04 16:17:59]

Acknowledged.

+}
+
+@property(nonatomic, readonly) autofill::PasswordForm passwordForm;
+@property(nonatomic, readonly) password_manager::CredentialType credentialType;
+
+// Initializes an item view populated with the data in |passwordForm|. Uses
+// |delegate| to asynchronously fetch the avatar image.
+- (id)initWithPasswordForm:(const autofill::PasswordForm&)passwordForm
+            credentialType:(password_manager::CredentialType)credentialType
+                  delegate:(id<CredentialItemDelegate>)delegate;
+
+// Sets a custom avatar for this item. The image should be scaled and cropped
+// to a circle of size |kAvatarImageSize|, otherwise it will look ridiculous.
+- (void)updateAvatar:(NSImage*)avatar;
+
+// The default avatar image, used when a custom one is not set.
++ (NSImage*)defaultAvatar;
+
+@end
+
+#endif  // CHROME_BROWSER_UI_COCOA_PASSWORDS_CREDENTIAL_ITEM_VIEW_H_