Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878743005: cc: Add some debugging info to failing DCHECK in PictureLayerTilingSet (Closed)

Created:
5 years, 10 months ago by danakj
Modified:
5 years, 10 months ago
Reviewers:
vmpstr, enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, ukai, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Add some debugging info to failing DCHECK in PictureLayerTilingSet Can't repro this locally so maybe some more info will help understand it. R=enne, vmpstr BUG=446751 Committed: https://crrev.com/f5d6cbeffb89d553aea776d2d65fd0061ce467d1 Cr-Commit-Position: refs/heads/master@{#314854}

Patch Set 1 #

Total comments: 4

Patch Set 2 : addcheck: . #

Patch Set 3 : addcheck: [ #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M cc/resources/picture_layer_tiling_set.cc View 1 2 2 chunks +12 lines, -13 lines 2 comments Download

Messages

Total messages: 10 (2 generated)
danakj
5 years, 10 months ago (2015-02-05 18:23:29 UTC) #1
vmpstr
lgtm with minor comments https://codereview.chromium.org/878743005/diff/1/cc/resources/picture_layer_tiling_set.cc File cc/resources/picture_layer_tiling_set.cc (right): https://codereview.chromium.org/878743005/diff/1/cc/resources/picture_layer_tiling_set.cc#newcode126 cc/resources/picture_layer_tiling_set.cc:126: if (twin_set) nit: wrap in ...
5 years, 10 months ago (2015-02-05 18:26:33 UTC) #2
danakj
PTAL https://codereview.chromium.org/878743005/diff/1/cc/resources/picture_layer_tiling_set.cc File cc/resources/picture_layer_tiling_set.cc (right): https://codereview.chromium.org/878743005/diff/1/cc/resources/picture_layer_tiling_set.cc#newcode126 cc/resources/picture_layer_tiling_set.cc:126: if (twin_set) On 2015/02/05 18:26:33, vmpstr wrote: > ...
5 years, 10 months ago (2015-02-05 18:32:03 UTC) #4
vmpstr
lgtm https://codereview.chromium.org/878743005/diff/40001/cc/resources/picture_layer_tiling_set.cc File cc/resources/picture_layer_tiling_set.cc (left): https://codereview.chromium.org/878743005/diff/40001/cc/resources/picture_layer_tiling_set.cc#oldcode119 cc/resources/picture_layer_tiling_set.cc:119: size_t num_high_res = std::count_if(tilings_.begin(), tilings_.end(), heh, oh yeah ...
5 years, 10 months ago (2015-02-05 18:35:08 UTC) #5
danakj
https://codereview.chromium.org/878743005/diff/40001/cc/resources/picture_layer_tiling_set.cc File cc/resources/picture_layer_tiling_set.cc (left): https://codereview.chromium.org/878743005/diff/40001/cc/resources/picture_layer_tiling_set.cc#oldcode119 cc/resources/picture_layer_tiling_set.cc:119: size_t num_high_res = std::count_if(tilings_.begin(), tilings_.end(), On 2015/02/05 18:35:08, vmpstr ...
5 years, 10 months ago (2015-02-05 18:35:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878743005/40001
5 years, 10 months ago (2015-02-05 18:36:45 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-05 19:27:53 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-05 19:29:45 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f5d6cbeffb89d553aea776d2d65fd0061ce467d1
Cr-Commit-Position: refs/heads/master@{#314854}

Powered by Google App Engine
This is Rietveld 408576698