Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 878713002: Fix to the GCM Account Tracker flooding on a stale refresh token (Closed)

Created:
5 years, 11 months ago by fgorski
Modified:
5 years, 11 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix to the GCM Account Tracker flooding on a stale refresh token As a solution to a problem the Account Tracker will assume a stale refresh token when it cannot get access token. Backoff logic in token fetcher handles the case where service might not be reachale and situations like that. If the user signs in properly the account will be re-added. BUG=452131 R=zea@chromium.org,dimich@chromium.org Committed: https://crrev.com/be981e7796e29eba1ab9c6e7c65d1c56b0840b5f Cr-Commit-Position: refs/heads/master@{#313136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/services/gcm/gcm_account_tracker.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/services/gcm/gcm_account_tracker_unittest.cc View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Nicolas Zea
lgtm
5 years, 11 months ago (2015-01-26 19:54:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878713002/1
5 years, 11 months ago (2015-01-26 20:41:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-26 21:07:46 UTC) #4
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 21:08:51 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be981e7796e29eba1ab9c6e7c65d1c56b0840b5f
Cr-Commit-Position: refs/heads/master@{#313136}

Powered by Google App Engine
This is Rietveld 408576698