Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 878673006: Reland "mac: Layer back the root view of the browser window on OSX 10.9+." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 1ed775b94c712b877308ada24d4dcebdcec701d6..b82ea107db20f1145862bfe8b7257b4b8d9452e0 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -1072,4 +1072,16 @@ willPositionSheet:(NSWindow*)sheet
return [super shouldConstrainFrameRect];
}
+- (BOOL)wantsRootViewToBeLayerBacked {
+ // This class always layer-backs the contentView of the window. If Chrome
+ // were linked against OSX 10.9, this would also cause the root view to be
+ // layer backed. Since Chrome is linked against OSX 10.6, the root view by
+ // default is not layer backed.
+
+ // This class is going to have a custom AppKit fullscreen animation, which
+ // requires that the root view is layer backed. To be safe, this class will
+ // only layer-back the root view on OSX 10.9+.
+ return base::mac::IsOSMavericksOrLater();
+}
+
@end // @implementation BrowserWindowController(Private)
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller_private.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698