Issue 8786: Fix default focused button in dialogs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8786: Fix default focused button in dialogs (Closed)

Created:
12 years, 1 month ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Some code in MessageBoxView was focusing the first focusable element in the view, overidding the focus set from the DialogDelegate. We now only rely on the dialog delegate. Also changed dialog delegate so the default button is also the focused button. BUG=98 TEST=Open a javascript alert then confirm dialog. A button should be focused. Open all dialogs in Chrome. A button should be focused by default. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=4334

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -25 lines)			Patch
M	chrome/browser/views/constrained_window_impl.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	chrome/views/dialog_delegate.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/views/dialog_delegate.cc	View		1 chunk	+22 lines, -3 lines	0 comments	Download
M	chrome/views/message_box_view.h	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/views/message_box_view.cc	View	1	1 chunk	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

hooray! LG

Expand Messages | Collapse Messages