Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 878573006: Fix Security Key proxying. (Closed)

Created:
5 years, 11 months ago by Jamie
Modified:
5 years, 11 months ago
Reviewers:
garykac
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Security Key proxying. Gnubby was added a a Capbility in https://codereview.chromium.org/787033003, but since it is not negotiated between host and client, that's not the right way to make it configurable. BUG=448131 Committed: https://crrev.com/fba61916fc0618e7ed05ccfc7b846311d499c6d2 Cr-Commit-Position: refs/heads/master@{#313181}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M remoting/webapp/crd/js/client_session.js View 2 chunks +1 line, -6 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie
ptal
5 years, 11 months ago (2015-01-26 23:08:07 UTC) #2
garykac
lgtm
5 years, 11 months ago (2015-01-26 23:12:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878573006/1
5 years, 11 months ago (2015-01-26 23:14:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 00:49:26 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 00:50:12 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fba61916fc0618e7ed05ccfc7b846311d499c6d2
Cr-Commit-Position: refs/heads/master@{#313181}

Powered by Google App Engine
This is Rietveld 408576698