Issue 878573005: Fix {virtual,override,final} build failure on official CrOS build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 878573005: Fix {virtual,override,final} build failure on official CrOS build (Closed)

Created:
5 years, 11 months ago by tbarzic

Modified:
5 years, 11 months ago

Reviewers:
Glenn Wilson, dcheng

CC:
dcheng, chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Fix {virtual,override,final} build failure on official CrOS build BUG=417463 TBR=gwilson@chromium.org Committed: https://crrev.com/457bc8a2cdd6cfcdb7a3ef379f72be8231ff3ee6 Cr-Commit-Position: refs/heads/master@{#313097}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/rlz/rlz_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878573005/1

5 years, 11 months ago (2015-01-26 18:16:57 UTC) #3

commit-bot: I haz the power

5 years, 11 months ago (2015-01-26 19:20:54 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/457bc8a2cdd6cfcdb7a3ef379f72be8231ff3ee6
Cr-Commit-Position: refs/heads/master@{#313097}