chrome/browser/ui/browser_tab_contents.cc - Issue 87853004: Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_tab_contents.cc

Issue 87853004: Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@movingclasses

Patch Set: adding new files Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/password_manager/password_manager.cc ('k') | chrome/browser/ui/gtk/location_bar_view_gtk.cc » ('j') | chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/browser_tab_contents.cc

diff --git a/chrome/browser/ui/browser_tab_contents.cc b/chrome/browser/ui/browser_tab_contents.cc

index ef5079e73fba83a894bf4ac6f9ed0c3e47749c83..72b220d1c1915bd50dd252c6d2f4822c2d9827f7 100644

--- a/chrome/browser/ui/browser_tab_contents.cc

+++ b/chrome/browser/ui/browser_tab_contents.cc

@@ -39,7 +39,7 @@

#include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"

#include "chrome/browser/ui/find_bar/find_tab_helper.h"

#include "chrome/browser/ui/hung_plugin_tab_helper.h"

-#include "chrome/browser/ui/passwords/manage_passwords_icon_controller.h"

+#include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"

#include "chrome/browser/ui/pdf/pdf_tab_helper.h"

#include "chrome/browser/ui/prefs/prefs_tab_helper.h"

#include "chrome/browser/ui/sad_tab_helper.h"

@@ -161,7 +161,7 @@ void BrowserTabContents::AttachTabHelpers(WebContents* web_contents) {

TabSpecificContentSettings::CreateForWebContents(web_contents);

ThumbnailTabHelper::CreateForWebContents(web_contents);

TranslateTabHelper::CreateForWebContents(web_contents);

- ManagePasswordsIconController::CreateForWebContents(web_contents);

+ ManagePasswordsBubbleUIController::CreateForWebContents(web_contents);

ZoomController::CreateForWebContents(web_contents);

#if defined(ENABLE_CAPTIVE_PORTAL_DETECTION)