Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings

chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index d409c467bda2915f1651e4babd68330a9e16e6eb..502aae058fa60d781a51cc96527ce2094796c502 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -5,7 +5,14 @@
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 
-#include "chrome/browser/content_settings/tab_specific_content_settings.h"
+#include "components/autofill/core/common/password_form.h"
+#include "content/public/browser/web_contents_observer.h"
+
+class ManagePasswordsIconController;
+
+namespace autofill {
+class PasswordForm;
+}
 
 namespace content {
 class WebContents;
@@ -35,7 +42,7 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
 
   // Called by the view code to delete or add a password form to the
   // PasswordStore.
-  void PasswordAction(autofill::PasswordForm password_form, bool remove);
+  void AddOrRemovePassword(autofill::PasswordForm password_form, bool remove);

[markusheintz_, 2013/11/26 12:44:37]

"Add" or "Remove" are two contradicting verbs that describe opposite actions.
This makes the method name very confusing and hard to understand. It is
discouraged to form method names like this. (There was a nice tot episode about
this, but a couldn't find it on go/tot so it's probably very old).

How about:
A) "OnPasswordAction"
B) "HandlePasswordAction"
C) "UpdatePassword"

as this seems to be a user input/ ui event handler.

[npentrel, 2013/11/26 14:25:55]

Done.

 
   // Called by the view code when the ManagePasswordItemView is destroyed and
   // the user chose to delete the password.
@@ -48,6 +55,7 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
   }
 
   bool password_submitted() { return password_submitted_; }
+

[markusheintz_, 2013/11/26 12:44:37]

nit: remove this empty line

[npentrel, 2013/11/26 14:25:55]

Done.

   const string16& title() { return title_; }
   const autofill::PasswordForm& pending_credentials() {
     return pending_credentials_;