Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3498)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h

Issue 87853004: Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@movingclasses
Patch Set: Android fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
index 7624978a30a31342116555a03193721b8662b7b4..4976dba3420c8d77b7bbefc18bf544ac0273bff5 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
+++ b/chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h
@@ -38,14 +38,14 @@ class ManagePasswordsBubbleView : public views::BubbleDelegateView,
static bool IsShowing();
private:
- ManagePasswordsBubbleView(views::View* anchor_view,
- content::WebContents* web_contents,
+ ManagePasswordsBubbleView(content::WebContents* web_contents,
+ views::View* anchor_view,
ManagePasswordsIconView* icon_view);
virtual ~ManagePasswordsBubbleView();
- // Returns the maximum width needed for the username or password field(s).
- // Both can take a maximum of 22 characters. If username is set it will return
- // the maximum width for the username, else the one for the password fields.
+ // Returns the maximum width needed for the username (if |username| is set) or
+ // password field, based on the actual usernames and passwords that need to be
+ // shown.
int GetMaximumUsernameOrPasswordWidth(bool username);
// If the bubble is not anchored to a view, places the bubble in the top

Powered by Google App Engine
This is Rietveld 408576698