chrome/browser/ui/views/location_bar/location_bar_view.cc - Issue 87853004: Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_bar_view.cc

Issue 87853004: Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@movingclasses

Patch Set: Android fix Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_icon_controller.cc ('k') | chrome/browser/ui/views/passwords/manage_password_item_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_bar_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_bar_view.cc b/chrome/browser/ui/views/location_bar/location_bar_view.cc

index c0beeaf6bfde970a5042ff7608bdc6367c54a48c..4001583a77450e3abad626e977ec86a285b96b82 100644

--- a/chrome/browser/ui/views/location_bar/location_bar_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_bar_view.cc

@@ -33,7 +33,7 @@

#include "chrome/browser/ui/omnibox/location_bar_util.h"

#include "chrome/browser/ui/omnibox/omnibox_popup_model.h"

#include "chrome/browser/ui/omnibox/omnibox_popup_view.h"

-#include "chrome/browser/ui/passwords/manage_passwords_icon_controller.h"

+#include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"

#include "chrome/browser/ui/tabs/tab_strip_model.h"

#include "chrome/browser/ui/view_ids.h"

#include "chrome/browser/ui/views/bookmarks/bookmark_prompt_view.h"

@@ -1394,7 +1394,7 @@ bool LocationBarView::RefreshManagePasswordsIconView() {

return false;

const bool was_visible = manage_passwords_icon_view_->visible();

manage_passwords_icon_view_->Update(

- ManagePasswordsIconController::FromWebContents(web_contents));

+ ManagePasswordsBubbleUIController::FromWebContents(web_contents));

return was_visible != manage_passwords_icon_view_->visible();

}

@@ -1417,7 +1417,7 @@ void LocationBarView::ShowManagePasswordsBubbleIfNeeded() {

if (!web_contents)

return;

manage_passwords_icon_view_->ShowBubbleIfNeeded(

- ManagePasswordsIconController::FromWebContents(web_contents));

+ ManagePasswordsBubbleUIController::FromWebContents(web_contents));

}

bool LocationBarView::HasValidSuggestText() const {