Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: chrome/browser/password_manager/password_manager.cc

Issue 87853004: Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@movingclasses
Patch Set: Android fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/password_manager.cc
diff --git a/chrome/browser/password_manager/password_manager.cc b/chrome/browser/password_manager/password_manager.cc
index f2e75a27d2d01f6d80b500a3d1d807c51d7113bb..cf3b2b388d0457a66867cc4a787e214029dacf94 100644
--- a/chrome/browser/password_manager/password_manager.cc
+++ b/chrome/browser/password_manager/password_manager.cc
@@ -11,11 +11,11 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/platform_thread.h"
-#include "chrome/browser/content_settings/tab_specific_content_settings.h"
#include "chrome/browser/password_manager/password_form_manager.h"
#include "chrome/browser/password_manager/password_manager_delegate.h"
#include "chrome/browser/password_manager/password_manager_metrics_util.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/passwords/manage_passwords_bubble_ui_controller.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/pref_names.h"
@@ -340,10 +340,10 @@ void PasswordManager::OnPasswordFormsRendered(
if (ShouldShowSavePasswordInfoBar()) {
if (CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableSavePasswordBubble)) {
- TabSpecificContentSettings* content_settings =
- TabSpecificContentSettings::FromWebContents(web_contents());
- if (content_settings) {
- content_settings->OnPasswordSubmitted(
+ ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller =
+ ManagePasswordsBubbleUIController::FromWebContents(web_contents());
+ if (manage_passwords_bubble_ui_controller) {
+ manage_passwords_bubble_ui_controller->OnPasswordSubmitted(
provisional_save_manager_.release());
} else {
provisional_save_manager_.reset();
@@ -429,8 +429,8 @@ void PasswordManager::Autofill(
break;
}
- TabSpecificContentSettings* content_settings =
- TabSpecificContentSettings::FromWebContents(web_contents());
- if (content_settings)
- content_settings->OnPasswordAutofilled(best_matches);
+ ManagePasswordsBubbleUIController* manage_passwords_bubble_ui_controller =
+ ManagePasswordsBubbleUIController::FromWebContents(web_contents());
+ if (manage_passwords_bubble_ui_controller)
+ manage_passwords_bubble_ui_controller->OnPasswordAutofilled(best_matches);
}
« no previous file with comments | « chrome/browser/content_settings/tab_specific_content_settings.cc ('k') | chrome/browser/ui/browser_tab_contents.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698