Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_icon_controller.h

Issue 87853004: Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@movingclasses
Patch Set: Android fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_icon_controller.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_icon_controller.h b/chrome/browser/ui/passwords/manage_passwords_icon_controller.h
deleted file mode 100644
index 6fea3d4c3b72f83ec38857d06724dd25b458219e..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/passwords/manage_passwords_icon_controller.h
+++ /dev/null
@@ -1,57 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_CONTROLLER_H_
-#define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_CONTROLLER_H_
-
-#include "chrome/browser/content_settings/tab_specific_content_settings.h"
-#include "content/public/browser/web_contents_observer.h"
-#include "content/public/browser/web_contents_user_data.h"
-
-namespace content {
-class WebContents;
-}
-
-// Per-tab class to control the Omnibox password icon's visibility.
-class ManagePasswordsIconController
- : public TabSpecificContentSettings::PasswordObserver,
- public content::WebContentsObserver,
- public content::WebContentsUserData<ManagePasswordsIconController> {
- public:
- virtual ~ManagePasswordsIconController();
-
- bool manage_passwords_icon_to_be_shown() const {
- return manage_passwords_icon_to_be_shown_;
- }
-
- bool password_to_be_saved() const {
- return password_to_be_saved_;
- }
-
- bool manage_passwords_bubble_needs_showing() const {
- return manage_passwords_bubble_needs_showing_;
- }
-
- // Called when the bubble is opened after the icon gets displayed. We change
- // the state to know that we do not need to pop up the bubble again.
- void OnBubbleShown();
-
- private:
- friend class content::WebContentsUserData<ManagePasswordsIconController>;
-
- explicit ManagePasswordsIconController(content::WebContents* web_contents);
-
- // TabSpecificContentSettings::PasswordObserver:
- virtual void OnPasswordAction() OVERRIDE;
-
- bool manage_passwords_icon_to_be_shown_;
- bool password_to_be_saved_;
- bool manage_passwords_bubble_needs_showing_;
-
- content::BrowserContext* browser_context_;
-
- DISALLOW_COPY_AND_ASSIGN(ManagePasswordsIconController);
-};
-
-#endif // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_ICON_CONTROLLER_H_

Powered by Google App Engine
This is Rietveld 408576698