Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1725)

Unified Diff: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc

Issue 87853004: Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@movingclasses
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
diff --git a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
index c641a1efa2f8c240ac14319d0d00e524441834d6..886e1885d2c867d5af42fe30ceb2197096aee385 100644
--- a/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
+++ b/chrome/browser/ui/views/passwords/manage_passwords_icon_view.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/views/passwords/manage_passwords_icon_view.h"
+#include "chrome/browser/ui/passwords/manage_passwords_controller.h"
#include "chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h"
#include "grit/generated_resources.h"
#include "grit/theme_resources.h"
@@ -22,28 +23,26 @@ ManagePasswordsIconView::ManagePasswordsIconView(
ManagePasswordsIconView::~ManagePasswordsIconView() {}
void ManagePasswordsIconView::Update(
- ManagePasswordsIconController* manage_passwords_icon_controller) {
- SetVisible(
- manage_passwords_icon_controller &&
- manage_passwords_icon_controller->manage_passwords_icon_to_be_shown() &&
- !location_bar_delegate_->GetToolbarModel()->input_in_progress());
+ ManagePasswordsController* manage_passwords_controller) {
+ SetVisible(manage_passwords_controller &&
+ manage_passwords_controller->manage_passwords_icon_to_be_shown() &&
+ !location_bar_delegate_->GetToolbarModel()->input_in_progress());
if (!visible()) {
ManagePasswordsBubbleView::CloseBubble();
return;
}
SetImage(ui::ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
IDR_SAVE_PASSWORD));
- SetTooltip(manage_passwords_icon_controller->password_to_be_saved());
+ SetTooltip(manage_passwords_controller->password_to_be_saved());
}
void ManagePasswordsIconView::ShowBubbleIfNeeded(
- ManagePasswordsIconController* manage_passwords_icon_controller) {
- if (manage_passwords_icon_controller->
- manage_passwords_bubble_needs_showing() &&
+ ManagePasswordsController* manage_passwords_controller) {
+ if (manage_passwords_controller->manage_passwords_bubble_needs_showing() &&
visible() && !ManagePasswordsBubbleView::IsShowing()) {
ManagePasswordsBubbleView::ShowBubble(
location_bar_delegate_->GetWebContents(), this);
- manage_passwords_icon_controller->OnBubbleShown();
+ manage_passwords_controller->OnBubbleShown();
}
}

Powered by Google App Engine
This is Rietveld 408576698