Refactoring Manage Passwords Bubble Code to exclude TabSpecificContentSettings

chrome/browser/ui/passwords/manage_passwords_controller.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_CONTROLLER_H_
+#define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_CONTROLLER_H_
+
+#include "chrome/browser/password_manager/password_form_manager.h"
+#include "content/public/browser/navigation_details.h"
+#include "content/public/browser/web_contents_observer.h"
+#include "content/public/browser/web_contents_user_data.h"
+
+namespace content {
+class WebContents;
+}
+
+// Per-tab class to control the Omnibox password icon and bubble.
+class ManagePasswordsController

[markusheintz_, 2013/11/26 12:44:37]

ManagePasswordsController is a very generic name that could be more specific. I
mean what's the controller for? settings page, bubble, icon, maybe something
else?

Since I have a hard time suggesting a better one you can keep it for now.

Alternative name:
ManagePasswordsBubbleController to emphasis that this is for the passwords
bubble of the omnibox. Unfortunately this does not mention the omnibox icon.

We could also rethink the relation of the model and the controller. Let's
discuss this offline how to proceed here.

[npentrel, 2013/11/26 14:25:55]

Done.

+    : public content::WebContentsObserver,
+      public content::WebContentsUserData<ManagePasswordsController> {
+ public:
+  virtual ~ManagePasswordsController();
+
+  // Called when the user submits a form containing login information, so we
+  // can handle later requests to save or blacklist that login information.
+  // This stores the provided object in form_manager_ and triggers the UI to
+  // prompt the user about whether they would like to save the password.
+  void OnPasswordSubmitted(PasswordFormManager* form_manager);
+
+  // Called when a form is autofilled with login information, so we can manage
+  // password credentials for the current site which are stored in
+  // |password_form_map|. This stores a copy of |password_form_map| and shows
+  // the manage password icon.
+  void OnPasswordAutofilled(const autofill::PasswordFormMap& password_form_map);
+
+  // TODO(npentrel) This ought to be changed. Best matches should be newly
+  // made when opening the ManagePasswordsBubble because there may have been
+  // changes to the best matches via the settings page. At the moment this also
+  // fails if one deletes a password when they are autofilled, as it still shows
+  // up after logging in and saving a password.
+  void RemoveFromBestMatches(autofill::PasswordForm password_form);
+
+  void SavePassword();
+
+  // Called when the bubble is opened after the icon gets displayed. We change
+  // the state to know that we do not need to pop up the bubble again.
+  void OnBubbleShown();
+
+  bool manage_passwords_icon_to_be_shown() const {
+    return manage_passwords_icon_to_be_shown_;
+  }
+
+  bool password_to_be_saved() const {
+    return password_to_be_saved_;
+  }
+
+  bool manage_passwords_bubble_needs_showing() const {
+    return manage_passwords_bubble_needs_showing_;
+  }
+
+  void unset_manage_passwords_bubble_needs_showing() {
+    manage_passwords_bubble_needs_showing_ = false;
+  }
+
+  void unset_password_to_be_saved() {
+    password_to_be_saved_ = false;
+  }
+
+  const autofill::PasswordForm pending_credentials() const {
+    return form_manager_->pending_credentials();
+  }
+
+  const autofill::PasswordFormMap best_matches() const {
+    return password_form_map_;
+  }
+
+  bool password_submitted() const {
+    return password_submitted_;
+  }
+
+  void set_password_submitted(bool password_submitted) {
+    password_submitted_ = password_submitted;
+  }
+
+ private:
+  friend class content::WebContentsUserData<ManagePasswordsController>;
+
+  explicit ManagePasswordsController(content::WebContents* web_contents);
+
+  // Called when a passwordform is autofilled, when a new passwordform is
+  // submitted, or when a navigation occurs to update the visibility of the
+  // manage passwords icon and bubble.
+  void OnPasswordAction();

[markusheintz_, 2013/11/26 12:44:37]

nit: I'll leave this name change up to you but "UpdateUi" or
"UpdateBubbleAndIconVisibility" seems more appropriate here since this is what
the method does.

OnPasswordAction is misleading since it does not suggest that the visibility
state is UI elements is changed and a Navigation is no passwords event.

[npentrel, 2013/11/26 14:25:55]

Done.

+
+  // content::WebContentsObserver:
+  virtual void DidNavigateMainFrame(
+      const content::LoadCommittedDetails& details,
+      const content::FrameNavigateParams& params) OVERRIDE;
+
+  // Set by OnPasswordSubmitted() when the user submits a form containing login
+  // information.  If the user responds to a subsequent "Do you want to save
+  // this password?" prompt, we ask this object to save or blacklist the
+  // associated login information in Chrome's password store.
+  scoped_ptr<PasswordFormManager> form_manager_;
+
+  // All previously stored credentials for a specific site.  Set by
+  // OnPasswordSubmitted() or OnPasswordAutofilled().
+  autofill::PasswordFormMap password_form_map_;
+
+  bool manage_passwords_icon_to_be_shown_;
+  bool password_to_be_saved_;
+  bool manage_passwords_bubble_needs_showing_;

[markusheintz_, 2013/11/26 12:44:37]

It would be great to add a comment for this field. Thanks

[npentrel, 2013/11/26 14:25:55]

Done.

+  bool password_submitted_;
+
+  DISALLOW_COPY_AND_ASSIGN(ManagePasswordsController);
+};
+
+#endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_CONTROLLER_H_