Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878523005: Show last updated time in About Chrome for non-official builds. (Closed)

Created:
5 years, 10 months ago by newt (away)
Modified:
5 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show last updated time in About Chrome for non-official builds. BUG=454037 Committed: https://crrev.com/d08c144c53a2210eaed781cc9b3da60dc1081983 Cr-Commit-Position: refs/heads/master@{#314249}

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment from #1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/AboutChromePreferences.java View 1 3 chunks +26 lines, -3 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
newt (away)
PTAL. thanks!
5 years, 10 months ago (2015-01-31 01:44:23 UTC) #2
nyquist
lgtm https://codereview.chromium.org/878523005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/AboutChromePreferences.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/AboutChromePreferences.java (right): https://codereview.chromium.org/878523005/diff/1/chrome/android/java/src/org/chromium/chrome/browser/preferences/AboutChromePreferences.java#newcode75 chrome/android/java/src/org/chromium/chrome/browser/preferences/AboutChromePreferences.java:75: } else { Nit: There's an early return ...
5 years, 10 months ago (2015-02-02 18:57:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878523005/20001
5 years, 10 months ago (2015-02-02 21:36:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 02:30:43 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 02:31:48 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d08c144c53a2210eaed781cc9b3da60dc1081983
Cr-Commit-Position: refs/heads/master@{#314249}

Powered by Google App Engine
This is Rietveld 408576698