extensions/renderer/script_injector.h - Issue 878513005: Extensions: suspend extension's scripts when V8 is paused

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/script_injector.h

Issue 878513005: Extensions: suspend extension's scripts when V8 is paused (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/renderer/script_injection_manager.cc ('K') | « extensions/renderer/script_injection_manager.cc ('k') | extensions/renderer/scripts_run_info.h » ('j') | extensions/renderer/scripts_run_info.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/script_injector.h

diff --git a/extensions/renderer/script_injector.h b/extensions/renderer/script_injector.h

index eeea4ea12ca4d424a0f086065a634b4e47c981b2..60c15517b9b2a8fe60c46e5e3556e6531bf392e3 100644

--- a/extensions/renderer/script_injector.h

+++ b/extensions/renderer/script_injector.h

@@ -76,11 +76,15 @@ class ScriptInjector {

virtual std::vector<std::string> GetCssSources(

UserScript::RunLocation run_location) const = 0;

+ // Fill scriptrs run info

Devlin 2015/03/03 00:34:10 nit: fix this comment.

kozy 2015/03/03 13:50:20 Done.

+ virtual void GetRunInfo(

+ ScriptsRunInfo* scripts_run_info,

+ UserScript::RunLocation run_location) const = 0;

// Notifies the script that injection has completed, with a possibly-populated

// list of results (depending on whether or not ExpectsResults() was true).

virtual void OnInjectionComplete(

scoped_ptr<base::ListValue> execution_results,

- ScriptsRunInfo* scripts_run_info,

UserScript::RunLocation run_location) = 0;

// Notifies the script that injection will never occur.