Extensions: suspend extension's scripts when V8 is paused

extensions/renderer/scripts_run_info.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/scripts_run_info.h"
 
 #include "base/metrics/histogram.h"
 #include "content/public/renderer/render_view.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/renderer/script_context.h"
@@ skipping 16 matching lines @@
     render_view->Send(new ExtensionHostMsg_ContentScriptsExecuting(
         render_view->GetRoutingID(),
         executing_scripts,
         ScriptContext::GetDataSourceURLForFrame(frame)));
   }
 
   switch (location) {
     case UserScript::DOCUMENT_START:
       UMA_HISTOGRAM_COUNTS_100("Extensions.InjectStart_CssCount", num_css);
       UMA_HISTOGRAM_COUNTS_100("Extensions.InjectStart_ScriptCount", num_js);
-      if (num_css || num_js)
+      if (num_blocking_js) {
+        UMA_HISTOGRAM_COUNTS_100("Extensions.InjectStart_BlockingScriptCount",
+                                 num_blocking_js);
+      } else if (num_css || num_js)

[Devlin, 2015/03/05 16:32:13]

if an "else" has brackets on one side, it should on the other, too.  So this
should be:
if (num_blocking_js) {
...
} else if (num_css || num_js) {
...
}

(Same for below.)

[kozy, 2015/03/05 21:41:37]

Done.

         UMA_HISTOGRAM_TIMES("Extensions.InjectStart_Time", timer.Elapsed());
       break;
     case UserScript::DOCUMENT_END:
       UMA_HISTOGRAM_COUNTS_100("Extensions.InjectEnd_ScriptCount", num_js);
-      if (num_js)
+      if (num_blocking_js) {
+        UMA_HISTOGRAM_COUNTS_100("Extensions.InjectEnd_BlockingScriptCount",
+                                 num_blocking_js);
+      } else if (num_js)
         UMA_HISTOGRAM_TIMES("Extensions.InjectEnd_Time", timer.Elapsed());
       break;
     case UserScript::DOCUMENT_IDLE:
       UMA_HISTOGRAM_COUNTS_100("Extensions.InjectIdle_ScriptCount", num_js);
-      if (num_js)
+      if (num_blocking_js) {
+        UMA_HISTOGRAM_COUNTS_100("Extensions.InjectIdle_BlockingScriptCount",
+                                 num_blocking_js);
+      } else if (num_js)
         UMA_HISTOGRAM_TIMES("Extensions.InjectIdle_Time", timer.Elapsed());
       break;
     case UserScript::RUN_DEFERRED:
     case UserScript::BROWSER_DRIVEN:
       // TODO(rdevlin.cronin): Add histograms.
       break;
     case UserScript::UNDEFINED:
     case UserScript::RUN_LOCATION_LAST:
       NOTREACHED();
   }
 }
 
 }  // namespace extensions