Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 878513003: Fix handle_watcher when start is called twice on the same handle. (Closed)

Created:
5 years, 10 months ago by ppi
Modified:
5 years, 10 months ago
Reviewers:
jamesr, qsr
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix handle_watcher when start is called twice on the same handle. This carries over a fix by qsr@ for the mojo helper handle_watcher landed in the mojo repo in https://codereview.chromium.org/781753004. The fix allows the network service apptests not to crash when built against the Chromium copy of mojo/common. BUG=450356 Committed: https://crrev.com/5e9a3adac10fdf8d172de5aa0d7ec9a7bbb1e441 Cr-Commit-Position: refs/heads/master@{#313261}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M mojo/common/handle_watcher.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/common/handle_watcher_unittest.cc View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ppi
Hi Ben, James, ptal.
5 years, 10 months ago (2015-01-26 15:36:41 UTC) #2
qsr
lgtm
5 years, 10 months ago (2015-01-26 15:40:18 UTC) #3
jamesr
lgtm, although this is a little bit bogus in that it's perfectly valid to have ...
5 years, 10 months ago (2015-01-26 20:37:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878513003/1
5 years, 10 months ago (2015-01-27 12:22:31 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 12:25:29 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 12:26:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5e9a3adac10fdf8d172de5aa0d7ec9a7bbb1e441
Cr-Commit-Position: refs/heads/master@{#313261}

Powered by Google App Engine
This is Rietveld 408576698