Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878463002: Fixed Privet v3 auth header. (Closed)

Created:
5 years, 11 months ago by Vitaly Buka (NO REVIEWS)
Modified:
5 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@patches
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed Privet v3 auth header. v1 uses "X-Privet-Auth". v3 uses "Authorization". Privet v3 client should use "Authorization: Privet anonymous" before pairing. BUG=449864 Committed: https://crrev.com/deefc1673351ea7d81a648f8a79e8f32d8524f9f Cr-Commit-Position: refs/heads/master@{#313144}

Patch Set 1 #

Patch Set 2 : Sun 01/25/2015 13:19:20.95 #

Patch Set 3 : Sun 01/25/2015 13:52:53.14 #

Patch Set 4 : Sun 01/25/2015 14:10:13.09 #

Total comments: 6

Patch Set 5 : Mon 01/26/2015 12:17:56.29 #

Patch Set 6 : Mon 01/26/2015 12:51:10.46 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -8 lines) Patch
M chrome/browser/local_discovery/privet_url_fetcher.cc View 1 2 3 4 5 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/local_discovery/privet_url_fetcher_unittest.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privetv3_session.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/local_discovery/privetv3_session.cc View 1 2 3 4 5 6 chunks +17 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Vitaly Buka (NO REVIEWS)
5 years, 11 months ago (2015-01-25 21:20:57 UTC) #2
Vitaly Buka (NO REVIEWS)
5 years, 11 months ago (2015-01-25 21:22:12 UTC) #3
Aleksey Shlyapnikov
lgtm https://codereview.chromium.org/878463002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc File chrome/browser/local_discovery/privetv3_session.cc (right): https://codereview.chromium.org/878463002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc#newcode24 chrome/browser/local_discovery/privetv3_session.cc:24: char kPrivetV3AuthAnonymous[] = "Privet anonymous"; const char https://codereview.chromium.org/878463002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc#newcode58 ...
5 years, 11 months ago (2015-01-26 20:12:17 UTC) #4
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/878463002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc File chrome/browser/local_discovery/privetv3_session.cc (right): https://codereview.chromium.org/878463002/diff/60001/chrome/browser/local_discovery/privetv3_session.cc#newcode24 chrome/browser/local_discovery/privetv3_session.cc:24: char kPrivetV3AuthAnonymous[] = "Privet anonymous"; On 2015/01/26 20:12:17, Aleksey ...
5 years, 11 months ago (2015-01-26 20:20:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878463002/80001
5 years, 11 months ago (2015-01-26 20:22:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878463002/100001
5 years, 11 months ago (2015-01-26 20:53:07 UTC) #10
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 11 months ago (2015-01-26 21:46:39 UTC) #11
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 21:48:29 UTC) #12
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/deefc1673351ea7d81a648f8a79e8f32d8524f9f
Cr-Commit-Position: refs/heads/master@{#313144}

Powered by Google App Engine
This is Rietveld 408576698