Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878413008: Remove WebsiteSettingsPopupLegacy. (Closed)

Created:
5 years, 10 months ago by aurimas (slooooooooow)
Modified:
5 years, 10 months ago
Reviewers:
Ted C, sashab
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebsiteSettingsPopupLegacy. WebsiteSettingsPopupLegacy was replaced with WebsiteSettingsPopup. This change removes the old dialog and it's dependencies. BUG=456167 Committed: https://crrev.com/00e86ade3b71d372ebe49c3e24da75361e841dc7 Cr-Commit-Position: refs/heads/master@{#315377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -906 lines) Patch
D chrome/android/java/res/drawable-hdpi/pageinfo_bad.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/pageinfo_enterprise_managed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/pageinfo_good.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/pageinfo_info.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/pageinfo_warning_minor.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/pageinfo_bad.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/pageinfo_enterprise_managed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/pageinfo_good.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/pageinfo_info.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/pageinfo_warning_minor.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/pageinfo_bad.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/pageinfo_enterprise_managed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/pageinfo_good.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/pageinfo_info.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/pageinfo_warning_minor.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/pageinfo_bad.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/pageinfo_enterprise_managed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/pageinfo_good.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/pageinfo_info.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/pageinfo_warning_minor.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/pageinfo_bad.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/pageinfo_enterprise_managed.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/pageinfo_good.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/pageinfo_info.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/pageinfo_warning_minor.png View Binary file 0 comments Download
D chrome/android/java/res/layout/website_settings_legacy.xml View 1 chunk +0 lines, -38 lines 0 comments Download
M chrome/android/java/res/values/colors.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/ChromeSwitches.java View 1 chunk +0 lines, -6 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/CertificateViewer.java View 1 chunk +0 lines, -232 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopup.java View 2 chunks +1 line, -7 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/WebsiteSettingsPopupLegacy.java View 1 chunk +0 lines, -245 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 4 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/android/resource_id.h View 1 chunk +0 lines, -11 lines 0 comments Download
D chrome/browser/ui/android/certificate_viewer_android.cc View 1 chunk +0 lines, -92 lines 0 comments Download
D chrome/browser/ui/android/website_settings_popup_legacy_android.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/ui/android/website_settings_popup_legacy_android.cc View 1 chunk +0 lines, -202 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
A + content/public/android/java/res/drawable-hdpi/ic_warning.png View Binary file 0 comments Download
D content/public/android/java/res/drawable-hdpi/pageinfo_warning_major.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-xhdpi/ic_warning.png View Binary file 0 comments Download
D content/public/android/java/res/drawable-xhdpi/pageinfo_warning_major.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-xxhdpi/ic_warning.png View Binary file 0 comments Download
D content/public/android/java/res/drawable-xxhdpi/pageinfo_warning_major.png View Binary file 0 comments Download
A + content/public/android/java/res/drawable-xxxhdpi/ic_warning.png View Binary file 0 comments Download
D content/public/android/java/res/drawable-xxxhdpi/pageinfo_warning_major.png View Binary file 0 comments Download
M content/public/android/java/res/layout/validation_message_bubble.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
aurimas (slooooooooow)
sashab and tedchoc: PTAL
5 years, 10 months ago (2015-02-06 19:34:43 UTC) #2
Ted C
lgtm
5 years, 10 months ago (2015-02-06 19:41:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878413008/1
5 years, 10 months ago (2015-02-09 18:36:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-09 20:40:08 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 20:40:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/00e86ade3b71d372ebe49c3e24da75361e841dc7
Cr-Commit-Position: refs/heads/master@{#315377}

Powered by Google App Engine
This is Rietveld 408576698