Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 878413005: Finalize rename of LayerImpl scroll offset methods. (Closed)

Created:
5 years, 10 months ago by aelias_OOO_until_Jul13
Modified:
5 years, 10 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Finalize rename of LayerImpl scroll offset methods. This deletes stubs and renames all uses in tests for the following methods that were renamed in https://codereview.chromium.org/800613009: - LayerImpl::TotalScrollOffset was renamed to CurrentScrollOffset. TotalScrollOffset is now a LayerTreeImpl-specific concept meaning the sum of the inner and outer viewport current scroll offsets. - LayerImpl::scroll_offset() was renamed to BaseScrollOffset. This is the latest scroll offset pushed from the main thread. - LayerImpl::SetScrollOffset() was renamed to PushScrollOffsetFromMainThread. There are two ways to change the scroll offset, either pushing from the main thread or directly doing SetCurrentScrollOffset, corresponding to main-thread or impl-thread scrolling. BUG= Committed: https://crrev.com/f998da84f5813c2874d0fcc2e71b44e8d4c04314 Cr-Commit-Position: refs/heads/master@{#314238}

Patch Set 1 #

Patch Set 2 : Fix perftest compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -202 lines) Patch
M cc/layers/layer_impl.h View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 11 chunks +73 lines, -72 lines 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 51 chunks +91 lines, -89 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_damage.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 16 chunks +28 lines, -27 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aelias_OOO_until_Jul13
PTAL.
5 years, 10 months ago (2015-02-02 22:55:18 UTC) #2
enne (OOO)
lgtm
5 years, 10 months ago (2015-02-02 22:59:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878413005/20001
5 years, 10 months ago (2015-02-02 23:32:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 01:41:21 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 01:42:22 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f998da84f5813c2874d0fcc2e71b44e8d4c04314
Cr-Commit-Position: refs/heads/master@{#314238}

Powered by Google App Engine
This is Rietveld 408576698