Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 878383002: text input focus: RemoveObserver when RenderProcessHost exits. (Closed)

Created:
5 years, 11 months ago by Yuki
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

text input focus: RemoveObserver when RenderProcessHost exits. Makes sure that a WebView as RenderProcessHostObserver is removed from RenderProcessHost's observer list when RenderProcessHost exits. BUG=290701 Committed: https://crrev.com/e3bd3d03b895a14e811912a06162efa316668ff9 Cr-Commit-Position: refs/heads/master@{#313662}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/views/controls/webview/webview.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yuki
sky@, could you review this CL? I've added a call to RemoveObserver as you suggested ...
5 years, 11 months ago (2015-01-28 09:37:09 UTC) #2
sky
LGTM - thanks
5 years, 10 months ago (2015-01-28 21:06:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878383002/1
5 years, 10 months ago (2015-01-29 03:54:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 03:59:13 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 04:00:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3bd3d03b895a14e811912a06162efa316668ff9
Cr-Commit-Position: refs/heads/master@{#313662}

Powered by Google App Engine
This is Rietveld 408576698