Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 878333002: fix operator precedence in test. (Closed)

Created:
5 years, 11 months ago by cpu_(ooo_6.6-7.5)
Modified:
5 years, 11 months ago
Reviewers:
mattm
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clarify operator precedence in test. VS /analyze complains about this. BUG=427616 Committed: https://crrev.com/4332d2efc6f9847851291eff6f93665eb6b08f99 Cr-Commit-Position: refs/heads/master@{#313429}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/safe_browsing/protocol_parser_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
cpu_(ooo_6.6-7.5)
this error e:\b\build\slave\chromium_windows_analyze\build\src\chrome\browser\safe_browsing\protocol_parser_unittest.cc(81) : warning C6336: Arithmetic operator has precedence over question operator, use parentheses ...
5 years, 11 months ago (2015-01-28 00:50:41 UTC) #2
mattm
lgtm
5 years, 11 months ago (2015-01-28 01:00:17 UTC) #3
mattm
On 2015/01/28 01:00:17, mattm wrote: > lgtm (though technically the precedence was okay already, just ...
5 years, 11 months ago (2015-01-28 01:01:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878333002/1
5 years, 11 months ago (2015-01-28 01:59:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-28 04:10:45 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-28 04:12:47 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4332d2efc6f9847851291eff6f93665eb6b08f99
Cr-Commit-Position: refs/heads/master@{#313429}

Powered by Google App Engine
This is Rietveld 408576698