Split skydb trace into start_tracing and stop_tracing

Split skydb trace into start_tracing and stop_tracing

Now stop_tracing writes the response to a file instead of spamming the trace data to stdout.

R=eseidel@chromium.org, esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a49a4af6654a0fb180493ebe98b236e39ce66570

[esprehn, 2015-01-27 20:59:23]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-01-27 20:59:24]

lgtm w/ fixes

https://codereview.chromium.org/878283002/diff/1/sky/tools/debugger/prompt/pr...
File sky/tools/debugger/prompt/prompt.cc (right):

https://codereview.chromium.org/878283002/diff/1/sky/tools/debugger/prompt/pr...
sky/tools/debugger/prompt/prompt.cc:170: Respond(connection_id, "Starting trace
(type 'trace' to stop tracing)\n");
is this right? Or do you need to type stop_tracing to stop?

https://codereview.chromium.org/878283002/diff/1/sky/tools/skydb
File sky/tools/skydb (right):

https://codereview.chromium.org/878283002/diff/1/sky/tools/skydb#newcode340
sky/tools/skydb:340: with open("sky_viewer.trace", "wb") as trace_file:
It'd be nice to take the name as an argument to stop_tracing so you can do 

sky-db stop_tracing -f with-opt.trace

and have less risk of stomping over an old trace you wanted.

[eseidel, 2015-01-27 21:07:22]

lgtm

https://codereview.chromium.org/878283002/diff/1/sky/tools/debugger/prompt/pr...
File sky/tools/debugger/prompt/prompt.cc (right):

https://codereview.chromium.org/878283002/diff/1/sky/tools/debugger/prompt/pr...
sky/tools/debugger/prompt/prompt.cc:166: is_tracing_ = true;
You don't need to check this, there are apis to tell if we're tracing last I
knew.

https://codereview.chromium.org/878283002/diff/1/sky/tools/skydb
File sky/tools/skydb (right):

https://codereview.chromium.org/878283002/diff/1/sky/tools/skydb#newcode340
sky/tools/skydb:340: with open("sky_viewer.trace", "wb") as trace_file:
On 2015/01/27 20:59:24, esprehn wrote:
> It'd be nice to take the name as an argument to stop_tracing so you can do 
> 
> sky-db stop_tracing -f with-opt.trace
> 
> and have less risk of stomping over an old trace you wanted.

You don't even need the -f, just simply a positional argument should work.

skydb stop_tracing foo.trace

https://codereview.chromium.org/878283002/diff/1/sky/tools/skydb#newcode577
sky/tools/skydb:577: 'starts tracing the running sky intance')
instance

[abarth-chromium, 2015-01-27 21:27:59]

https://codereview.chromium.org/878283002/diff/1/sky/tools/debugger/prompt/pr...
File sky/tools/debugger/prompt/prompt.cc (right):

https://codereview.chromium.org/878283002/diff/1/sky/tools/debugger/prompt/pr...
sky/tools/debugger/prompt/prompt.cc:166: is_tracing_ = true;
On 2015/01/27 at 21:07:21, eseidel wrote:
> You don't need to check this, there are apis to tell if we're tracing last I
knew.

We're using mojo's multiapp tracing system to trace all the DLLs at once.

https://codereview.chromium.org/878283002/diff/1/sky/tools/debugger/prompt/pr...
sky/tools/debugger/prompt/prompt.cc:170: Respond(connection_id, "Starting trace
(type 'trace' to stop tracing)\n");
On 2015/01/27 at 20:59:24, esprehn wrote:
> is this right? Or do you need to type stop_tracing to stop?

Ah, will fix.

https://codereview.chromium.org/878283002/diff/1/sky/tools/skydb
File sky/tools/skydb (right):

https://codereview.chromium.org/878283002/diff/1/sky/tools/skydb#newcode340
sky/tools/skydb:340: with open("sky_viewer.trace", "wb") as trace_file:
Will do!

https://codereview.chromium.org/878283002/diff/1/sky/tools/skydb#newcode577
sky/tools/skydb:577: 'starts tracing the running sky intance')
On 2015/01/27 at 21:07:22, eseidel wrote:
> instance

Done.

[abarth-chromium, 2015-01-27 21:58:35]

Committed patchset #2 (id:20001) manually as
a49a4af6654a0fb180493ebe98b236e39ce66570 (presubmit successful).