Index: src/ic/ia32/ic-ia32.cc |
diff --git a/src/ic/ia32/ic-ia32.cc b/src/ic/ia32/ic-ia32.cc |
index bdaa1f4a995063868117141f898e047722a668cb..c302e85d178eb48cfcbd1089c4a0c140549d738c 100644 |
--- a/src/ic/ia32/ic-ia32.cc |
+++ b/src/ic/ia32/ic-ia32.cc |
@@ -330,7 +330,7 @@ static Operand GenerateUnmappedArgumentsLookup(MacroAssembler* masm, |
} |
-void KeyedLoadIC::GenerateGeneric(MacroAssembler* masm) { |
+void KeyedLoadIC::GenerateMegamorphic(MacroAssembler* masm) { |
// The return address is on the stack. |
Label slow, check_name, index_smi, index_name, property_array_property; |
Label probe_dictionary, check_number_dictionary; |
@@ -392,95 +392,19 @@ void KeyedLoadIC::GenerateGeneric(MacroAssembler* masm) { |
GenerateKeyedLoadReceiverCheck(masm, receiver, eax, Map::kHasNamedInterceptor, |
&slow); |
- // If the receiver is a fast-case object, check the keyed lookup |
- // cache. Otherwise probe the dictionary. |
+ // If the receiver is a fast-case object, check the stub cache. Otherwise |
+ // probe the dictionary. |
__ mov(ebx, FieldOperand(receiver, JSObject::kPropertiesOffset)); |
__ cmp(FieldOperand(ebx, HeapObject::kMapOffset), |
Immediate(isolate->factory()->hash_table_map())); |
__ j(equal, &probe_dictionary); |
- // The receiver's map is still in eax, compute the keyed lookup cache hash |
- // based on 32 bits of the map pointer and the string hash. |
- if (FLAG_debug_code) { |
- __ cmp(eax, FieldOperand(receiver, HeapObject::kMapOffset)); |
- __ Check(equal, kMapIsNoLongerInEax); |
- } |
- __ mov(ebx, eax); // Keep the map around for later. |
- __ shr(eax, KeyedLookupCache::kMapHashShift); |
- __ mov(edi, FieldOperand(key, String::kHashFieldOffset)); |
- __ shr(edi, String::kHashShift); |
- __ xor_(eax, edi); |
- __ and_(eax, KeyedLookupCache::kCapacityMask & KeyedLookupCache::kHashMask); |
- |
- // Load the key (consisting of map and internalized string) from the cache and |
- // check for match. |
- Label load_in_object_property; |
- static const int kEntriesPerBucket = KeyedLookupCache::kEntriesPerBucket; |
- Label hit_on_nth_entry[kEntriesPerBucket]; |
- ExternalReference cache_keys = |
- ExternalReference::keyed_lookup_cache_keys(masm->isolate()); |
- |
- for (int i = 0; i < kEntriesPerBucket - 1; i++) { |
- Label try_next_entry; |
- __ mov(edi, eax); |
- __ shl(edi, kPointerSizeLog2 + 1); |
- if (i != 0) { |
- __ add(edi, Immediate(kPointerSize * i * 2)); |
- } |
- __ cmp(ebx, Operand::StaticArray(edi, times_1, cache_keys)); |
- __ j(not_equal, &try_next_entry); |
- __ add(edi, Immediate(kPointerSize)); |
- __ cmp(key, Operand::StaticArray(edi, times_1, cache_keys)); |
- __ j(equal, &hit_on_nth_entry[i]); |
- __ bind(&try_next_entry); |
- } |
- |
- __ lea(edi, Operand(eax, 1)); |
- __ shl(edi, kPointerSizeLog2 + 1); |
- __ add(edi, Immediate(kPointerSize * (kEntriesPerBucket - 1) * 2)); |
- __ cmp(ebx, Operand::StaticArray(edi, times_1, cache_keys)); |
- __ j(not_equal, &slow); |
- __ add(edi, Immediate(kPointerSize)); |
- __ cmp(key, Operand::StaticArray(edi, times_1, cache_keys)); |
- __ j(not_equal, &slow); |
- |
- // Get field offset. |
- // ebx : receiver's map |
- // eax : lookup cache index |
- ExternalReference cache_field_offsets = |
- ExternalReference::keyed_lookup_cache_field_offsets(masm->isolate()); |
- |
- // Hit on nth entry. |
- for (int i = kEntriesPerBucket - 1; i >= 0; i--) { |
- __ bind(&hit_on_nth_entry[i]); |
- if (i != 0) { |
- __ add(eax, Immediate(i)); |
- } |
- __ mov(edi, |
- Operand::StaticArray(eax, times_pointer_size, cache_field_offsets)); |
- __ movzx_b(eax, FieldOperand(ebx, Map::kInObjectPropertiesOffset)); |
- __ sub(edi, eax); |
- __ j(above_equal, &property_array_property); |
- if (i != 0) { |
- __ jmp(&load_in_object_property); |
- } |
- } |
- |
- // Load in-object property. |
- __ bind(&load_in_object_property); |
- __ movzx_b(eax, FieldOperand(ebx, Map::kInstanceSizeOffset)); |
- __ add(eax, edi); |
- __ mov(eax, FieldOperand(receiver, eax, times_pointer_size, 0)); |
- __ IncrementCounter(counters->keyed_load_generic_lookup_cache(), 1); |
- __ ret(0); |
- |
- // Load property array property. |
- __ bind(&property_array_property); |
- __ mov(eax, FieldOperand(receiver, JSObject::kPropertiesOffset)); |
- __ mov(eax, |
- FieldOperand(eax, edi, times_pointer_size, FixedArray::kHeaderSize)); |
- __ IncrementCounter(counters->keyed_load_generic_lookup_cache(), 1); |
- __ ret(0); |
+ Code::Flags flags = Code::RemoveTypeAndHolderFromFlags( |
+ Code::ComputeHandlerFlags(Code::LOAD_IC)); |
+ masm->isolate()->stub_cache()->GenerateProbe( |
+ masm, Code::LOAD_IC, flags, false, receiver, key, ebx, no_reg); |
+ // Cache miss. |
+ GenerateMiss(masm); |
// Do a quick inline probe of the receiver's dictionary, if it |
// exists. |