Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 878253002: LocalizedValuesBuilder moved to components/login. (Closed)

Created:
5 years, 11 months ago by dzhioev (left Google)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, dcheng, pam+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LocalizedValuesBuilder moved to components/login. In addition |prefix| parameter added to constructor. If prefix is given, it is added to the beginning of every registered key. BUG=none TBR=jshin@chromium.org Committed: https://crrev.com/420295a0cc571c40ddc4be20877c7d81aa3cda0a Cr-Commit-Position: refs/heads/master@{#315301}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Removed dependency on 'base'. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -153 lines) Patch
M chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/app_launch_splash_screen_handler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/auto_enrollment_check_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.h View 3 chunks +6 lines, -53 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc View 3 chunks +2 lines, -50 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/controller_pairing_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/device_disabled_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/enrollment_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/error_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/hid_detection_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/host_pairing_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_autolaunch_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_enable_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_dropdown_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/terms_of_service_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/update_screen_handler.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_board_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/wrong_hwid_screen_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/OWNERS View 1 1 chunk +6 lines, -0 lines 0 comments Download
M components/login.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M components/login/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A + components/login/DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
A components/login/localized_values_builder.h View 1 chunk +75 lines, -0 lines 0 comments Download
A components/login/localized_values_builder.cc View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
dzhioev (left Google)
Hello, please review. blundell@ -- components/OWNERS antrim@ -- the rest.
5 years, 11 months ago (2015-01-27 19:18:15 UTC) #2
blundell
//components lgtm
5 years, 10 months ago (2015-01-29 08:08:17 UTC) #3
Denis Kuznetsov (DE-MUC)
lgtm
5 years, 10 months ago (2015-01-30 17:40:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878253002/1
5 years, 10 months ago (2015-01-30 18:22:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/39482)
5 years, 10 months ago (2015-01-30 18:28:04 UTC) #8
dzhioev (left Google)
+thestig@ for 'base' dependency in 'components/login/DEPS' +jshik@ for 'ui/base/l10n' dependensy in 'components/login/DEPS'
5 years, 10 months ago (2015-02-05 13:34:51 UTC) #10
blundell
On 2015/02/05 13:34:51, dzhioev wrote: > +thestig@ for 'base' dependency in 'components/login/DEPS' > +jshik@ for ...
5 years, 10 months ago (2015-02-05 13:43:38 UTC) #11
Lei Zhang
On 2015/02/05 13:34:51, dzhioev wrote: > +thestig@ for 'base' dependency in 'components/login/DEPS' > +jshik@ for ...
5 years, 10 months ago (2015-02-05 17:53:36 UTC) #12
dzhioev (left Google)
On 2015/02/05 17:53:36, Lei Zhang wrote: > On 2015/02/05 13:34:51, dzhioev wrote: > > +thestig@ ...
5 years, 10 months ago (2015-02-09 13:18:19 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878253002/40001
5 years, 10 months ago (2015-02-09 13:22:07 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-09 15:12:20 UTC) #18
commit-bot: I haz the power
5 years, 10 months ago (2015-02-09 15:15:08 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/420295a0cc571c40ddc4be20877c7d81aa3cda0a
Cr-Commit-Position: refs/heads/master@{#315301}

Powered by Google App Engine
This is Rietveld 408576698