Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 878223002: Fix Histogram shadowing warning on vs2015 (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, erikwright+watch_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Histogram shadowing warning on vs2015 d:\src\cr3\src\base\metrics\histogram.cc(498): warning C4457: declaration of 'count' hides function parameter d:\src\cr3\src\base\metrics\histogram.cc(490): note: see declaration of 'count' R=isherman@chromium.org BUG=440500 Committed: https://crrev.com/dcc933d085af63675b27aa499717b97deb5489a2 Cr-Commit-Position: refs/heads/master@{#313361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/metrics/histogram.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
5 years, 10 months ago (2015-01-27 18:46:51 UTC) #2
Ilya Sherman
LGTM, thanks.
5 years, 10 months ago (2015-01-27 21:33:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878223002/1
5 years, 10 months ago (2015-01-27 21:34:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-27 21:38:27 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-27 21:39:29 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcc933d085af63675b27aa499717b97deb5489a2
Cr-Commit-Position: refs/heads/master@{#313361}

Powered by Google App Engine
This is Rietveld 408576698