Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 878173002: Removed kAshDisableTextFilteringInOverviewMode flag. (Closed)

Created:
5 years, 10 months ago by Nina
Modified:
5 years, 10 months ago
Reviewers:
*flackr, *tdanderson
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed kAshDisableTextFilteringInOverviewMode flag. Now that the text filtering feature is mature, we can remove the flag that allows disabling it safely. BUG=452107 TEST=manual Committed: https://crrev.com/a3f6c9fe77dad444455ae4bf5474c3ead2c01b4b Cr-Commit-Position: refs/heads/master@{#313776}

Patch Set 1 #

Patch Set 2 : Adding back some code I accidentally removed #

Patch Set 3 : Added a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -26 lines) Patch
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ash/wm/overview/window_grid.cc View 1 2 1 chunk +3 lines, -10 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Nina
Terry, can you give this patch a quick look before I send it to sky? ...
5 years, 10 months ago (2015-01-27 16:12:52 UTC) #2
Nina
Terry, just realized you own some of the files, added you as required reviewer!
5 years, 10 months ago (2015-01-27 16:14:33 UTC) #4
tdanderson
lgtm!
5 years, 10 months ago (2015-01-27 16:30:09 UTC) #5
Nina
Rob, can you give this patch a quick look? Thanks1
5 years, 10 months ago (2015-01-27 16:51:28 UTC) #8
flackr
LGTM
5 years, 10 months ago (2015-01-29 17:00:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878173002/40001
5 years, 10 months ago (2015-01-29 20:29:02 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-01-29 20:33:23 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 20:34:31 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3f6c9fe77dad444455ae4bf5474c3ead2c01b4b
Cr-Commit-Position: refs/heads/master@{#313776}

Powered by Google App Engine
This is Rietveld 408576698