[Android] Convert ContentShellTest.apk to isolate.

[Android] Convert ContentShellTest.apk to isolate.

We were previously using --test-data to push files from
//content/test/data/android/device_files to
$EXTERNAL_STORAGE/chrome/test/data/content. Switching to isolate lets
us handle all of our instrumentation and gtest data dependencies in the
same way. It will also facilitate using isolate to optimize transfers
between builders and testers.

BUG=400499
TBR=maruel@chromium.org

Committed: https://crrev.com/4cf59ffaa830d5edad26a439ba13f07ce0447394
Cr-Commit-Position: refs/heads/master@{#315148}

[jbudorick, 2015-01-28 18:36:37]

jbudorick@chromium.org changed reviewers:
+ klundberg@chromium.org, nyquist@chromium.org, tedchoc@chromium.org

[jbudorick, 2015-01-28 18:36:38]

nyquist: base/
klundberg: build/android/
tedchoc: content/

[nyquist, 2015-01-28 23:19:49]

Could you expand a bit in the CL description?

You are adding TODO's in //base for example; what are the steps missing to get
to that stage?

The bug is closed to external readers, so adding a more thorough description
would be very helpful I believe.

For example mention things like: What did we do before, how would this help us
going forward?

other than that, //base lgtm if you add the links to the bug.

https://codereview.chromium.org/878163004/diff/40001/base/test/android/javate...
File base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java
(right):

https://codereview.chromium.org/878163004/diff/40001/base/test/android/javate...
base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java:22: //
TODO(jbudorick): Remove DATA_DIR once everything has been isolated.
Could you please refer to the bug here and below?

[jbudorick, 2015-01-29 00:46:13]

On 2015/01/28 23:19:49, nyquist wrote:
> Could you expand a bit in the CL description?
> 

done

> You are adding TODO's in //base for example; what are the steps missing to get
> to that stage?
> 

There are three stages to this conversion:
 1) Update instrumentation tests to expect their data dependencies to be located
at $EXTERNAL_STORAGE/relative/path/to/data/dep (vs what they currently expect,
$EXTERNAL_STORAGE/chrome/test/data/<top_level_directory>/<path_relative_to_device_files>)
and change calls to getIsolatedTestFilePath
 2) Once all of those conversions are done, switch the implementation of
getTestFilePath to match the implementation of getIsolatedTestFilePath and
switch callers back to getTestFilePath
 3) Once everything has switched back to getTestFilePath, remove
getIsolatedTestFilePath

I could do these all in two very large patches (one upstream, one downstream w/
roll), but that seemed way too risky.

> The bug is closed to external readers, so adding a more thorough description
> would be very helpful I believe.
> 
> For example mention things like: What did we do before, how would this help us
> going forward?
> 
> other than that, //base lgtm if you add the links to the bug.
> 
>
https://codereview.chromium.org/878163004/diff/40001/base/test/android/javate...
> File base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java
> (right):
> 
>
https://codereview.chromium.org/878163004/diff/40001/base/test/android/javate...
> base/test/android/javatests/src/org/chromium/base/test/util/UrlUtils.java:22:
//
> TODO(jbudorick): Remove DATA_DIR once everything has been isolated.
> Could you please refer to the bug here and below?

done

[jbudorick, 2015-02-06 15:23:04]

klundberg, tedchoc: friendly ping

[klundberg, 2015-02-06 15:42:57]

lgtm

[Ted C, 2015-02-06 18:22:02]

lgtm

[jbudorick, 2015-02-06 21:17:51]

New patchsets have been uploaded after l-g-t-m from
klundberg@chromium.org,tedchoc@chromium.org

[jbudorick, 2015-02-06 22:37:52]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-02-06 22:38:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/878163004/100001

[commit-bot: I haz the power, 2015-02-06 22:46:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 22:46:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbudorick, 2015-02-06 22:48:47]

jbudorick@chromium.org changed reviewers:
+ maruel@chromium.org

[jbudorick, 2015-02-06 22:48:48]

TBR maruel for content_shell_test_apk.isolate

[jbudorick, 2015-02-06 22:48:54]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2015-02-06 22:50:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/878163004/100001

[commit-bot: I haz the power, 2015-02-07 00:43:34]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-02-07 00:44:05]

Patchset 6 (id:??) landed as
https://crrev.com/4cf59ffaa830d5edad26a439ba13f07ce0447394
Cr-Commit-Position: refs/heads/master@{#315148}

[Dirk Pranke, 2015-02-07 23:10:24]

Unfortunately, it looks like this CL broke the
contentshell_instrumentation_steps test on the chromium.webkit waterfall:

https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28db...

I'm not quite sure what to do about that, as it looks like the chromium.webkit
bot is not even using a recipe and is
probably running tests quite differently, so I'm not sure how easy this will be
to fix. 

I'm reverting this change for now, and we can discuss how to move forward.

[jbudorick, 2015-02-08 01:00:27]

On 2015/02/07 23:10:24, Dirk Pranke wrote:
> Unfortunately, it looks like this CL broke the
> contentshell_instrumentation_steps test on the chromium.webkit waterfall:
> 
>
https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28db...
> 
> I'm not quite sure what to do about that, as it looks like the chromium.webkit
> bot is not even using a recipe and is
> probably running tests quite differently, so I'm not sure how easy this will
be
> to fix. 
> 
> I'm reverting this change for now, and we can discuss how to move forward.

Ah, I think that's still on the old scripts in build/android/buildbot/. I'll
update those, then attempt to reland this. Thanks for reverting.