Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 878143003: [Win] Fix crash if the profile dir cannot be created (Closed)

Created:
5 years, 10 months ago by noms (inactive)
Modified:
5 years, 10 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win] Fix crash if the profile dir cannot be created If the profile is NULL, the code will hit the CHECK on line 389 anyway. BUG=414332 Committed: https://crrev.com/82e87d588df3a7334cf542ce68c9614869745f70 Cr-Commit-Position: refs/heads/master@{#313709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M chrome/browser/chrome_browser_main.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
noms (inactive)
If the profile cannot be initialized, then Chrome crashes when the profile tries to be ...
5 years, 10 months ago (2015-01-29 03:09:16 UTC) #2
sky
LGTM
5 years, 10 months ago (2015-01-29 14:26:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878143003/1
5 years, 10 months ago (2015-01-29 14:39:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 15:28:10 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-29 15:29:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82e87d588df3a7334cf542ce68c9614869745f70
Cr-Commit-Position: refs/heads/master@{#313709}

Powered by Google App Engine
This is Rietveld 408576698