Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878143002: Clean up time_formatting_unittest.cc now that chromium icu has been updated (Closed)

Created:
5 years, 11 months ago by Paweł Hajdan Jr.
Modified:
5 years, 10 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up time_formatting_unittest.cc now that chromium icu has been updated BUG=none R=jshin@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8201598dd59fd92ee787ad9f1d875f78b759e8af

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -17 lines) Patch
M base/i18n/time_formatting_unittest.cc View 2 chunks +0 lines, -17 lines 1 comment Download

Messages

Total messages: 6 (1 generated)
Paweł Hajdan Jr.
5 years, 11 months ago (2015-01-27 14:41:42 UTC) #2
jungshik at Google
On 2015/01/27 14:41:42, Paweł Hajdan Jr. wrote: LGTM
5 years, 10 months ago (2015-01-29 20:16:38 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8201598dd59fd92ee787ad9f1d875f78b759e8af Cr-Commit-Position: refs/heads/master@{#313900}
5 years, 10 months ago (2015-01-30 11:44:33 UTC) #4
Paweł Hajdan Jr.
Committed patchset #1 (id:1) manually as 8201598dd59fd92ee787ad9f1d875f78b759e8af (presubmit successful).
5 years, 10 months ago (2015-01-30 11:44:39 UTC) #5
jungshik at Google
5 years, 10 months ago (2015-02-03 21:49:09 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/878143002/diff/1/base/i18n/time_formatting_un...
File base/i18n/time_formatting_unittest.cc (right):

https://codereview.chromium.org/878143002/diff/1/base/i18n/time_formatting_un...
base/i18n/time_formatting_unittest.cc:11: #include
"third_party/icu/source/common/unicode/uversion.h"
Sorry that I forgot to point this out. You don't need this header any more, do
you?

Powered by Google App Engine
This is Rietveld 408576698