Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 878063002: [x86] Disable AVX unless the operating system explicitly claims to support it. (Closed)

Created:
5 years, 11 months ago by Benedikt Meurer
Modified:
5 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x86] Disable AVX unless the operating system explicitly claims to support it. BUG=chromium:452033, v8:3846 LOG=y R=jkummerow@chromium.org Committed: https://crrev.com/d93c4d19f13736c0538f4f66ca4a4a08d0cab9ca Cr-Commit-Position: refs/heads/master@{#26288}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -42 lines) Patch
M src/base/cpu.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/base/cpu.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/ia32/assembler-ia32.cc View 1 4 chunks +33 lines, -21 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 4 chunks +32 lines, -20 lines 0 comments Download
M test/unittests/base/cpu-unittest.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
5 years, 11 months ago (2015-01-27 08:54:08 UTC) #1
Benedikt Meurer
PTAL
5 years, 11 months ago (2015-01-27 08:54:36 UTC) #2
Jakob Kummerow
Beautiful. LGTM. https://codereview.chromium.org/878063002/diff/1/src/ia32/assembler-ia32.cc File src/ia32/assembler-ia32.cc (right): https://codereview.chromium.org/878063002/diff/1/src/ia32/assembler-ia32.cc#newcode94 src/ia32/assembler-ia32.cc:94: __asm _emit 0x0f __asm _emit 0x01 __asm ...
5 years, 11 months ago (2015-01-27 09:07:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878063002/1
5 years, 11 months ago (2015-01-27 09:08:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878063002/20001
5 years, 11 months ago (2015-01-27 09:29:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 09:59:24 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 09:59:35 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d93c4d19f13736c0538f4f66ca4a4a08d0cab9ca
Cr-Commit-Position: refs/heads/master@{#26288}

Powered by Google App Engine
This is Rietveld 408576698