Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 878033005: Move 'super-long post delayed task' warning to IncomingTaskQueue. (Closed)

Created:
5 years, 11 months ago by miu
Modified:
5 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move 'super-long post delayed task' warning to IncomingTaskQueue. This is a follow-up based on TBR review comments made to this change: https://codereview.chromium.org/873393004 This moves the warning message to a more-central location so that posting delayed tasks from additional call points (eg., MessageLoopProxy) will be checked. BUG=450045 Committed: https://crrev.com/5d4e9ddd94d94e02c2ec008a3465305a1feb3c1e Cr-Commit-Position: refs/heads/master@{#314392}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -15 lines) Patch
M base/message_loop/incoming_task_queue.cc View 3 chunks +13 lines, -0 lines 0 comments Download
M base/message_loop/message_loop.cc View 4 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
miu
darin: PTAL. This is a TBR follow-up on your comments from here: https://codereview.chromium.org/873393004 See my ...
5 years, 10 months ago (2015-01-28 19:30:30 UTC) #3
miu
Here's an example from a Debug_x64 build on my dev desktop: $ cat LAST_CHROME_LOG.txt | ...
5 years, 10 months ago (2015-01-28 19:33:44 UTC) #4
miu
Also, scottmg@ and I were discussing the threshold in https://crbug.com/450045. It seems the current threshold ...
5 years, 10 months ago (2015-01-28 20:29:56 UTC) #5
miu
darin: Friendly ping.
5 years, 10 months ago (2015-02-03 04:47:34 UTC) #6
darin (slow to review)
LGTM (apologies for the delay)
5 years, 10 months ago (2015-02-03 18:30:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878033005/20001
5 years, 10 months ago (2015-02-03 18:58:19 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-03 20:10:53 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 20:11:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d4e9ddd94d94e02c2ec008a3465305a1feb3c1e
Cr-Commit-Position: refs/heads/master@{#314392}

Powered by Google App Engine
This is Rietveld 408576698