Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 878023003: MIPS: Fix 'Load API accessor from descriptor instead of embedding it in handler.' (Closed)

Created:
5 years, 10 months ago by balazs.kilvady
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fix 'Load API accessor from descriptor instead of embedding it in handler.' Fix a typo in 6ea31f7eee230228c9d34362360b8b9f08e79815 BUG= Committed: https://crrev.com/c12d79257ec14dcc09b6dae31048dc1ec395076f Cr-Commit-Position: refs/heads/master@{#26335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
5 years, 10 months ago (2015-01-29 18:02:15 UTC) #2
paul.l...
lgtm
5 years, 10 months ago (2015-01-29 18:02:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/878023003/1
5 years, 10 months ago (2015-01-29 18:04:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-29 18:33:52 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c12d79257ec14dcc09b6dae31048dc1ec395076f Cr-Commit-Position: refs/heads/master@{#26335}
5 years, 10 months ago (2015-01-29 18:34:07 UTC) #7
ulan
5 years, 10 months ago (2015-01-30 12:12:57 UTC) #8
Message was sent while issue was closed.
On 2015/01/29 18:34:07, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/c12d79257ec14dcc09b6dae31048dc1ec395076f
> Cr-Commit-Position: refs/heads/master@{#26335}

LGTM. I forgot to update mips, sorry for the trouble.

Powered by Google App Engine
This is Rietveld 408576698