Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: sky/engine/core/rendering/RenderBox.cpp

Issue 878023002: Merge outline paint phases into the foreground phase. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderBox.cpp
diff --git a/sky/engine/core/rendering/RenderBox.cpp b/sky/engine/core/rendering/RenderBox.cpp
index beacebc15890daae1f61db7a925d377b1a3c0d8e..fec1bbaec89120970a6a7e00dfcddb63aecce095 100644
--- a/sky/engine/core/rendering/RenderBox.cpp
+++ b/sky/engine/core/rendering/RenderBox.cpp
@@ -795,7 +795,7 @@ void RenderBox::paintFillLayer(const PaintInfo& paintInfo, const Color& c, const
bool RenderBox::pushContentsClip(PaintInfo& paintInfo, const LayoutPoint& accumulatedOffset, ContentsClipBehavior contentsClipBehavior)
{
- if (paintInfo.phase == PaintPhaseSelfOutline || paintInfo.phase == PaintPhaseMask)
+ if (paintInfo.phase == PaintPhaseMask)
return false;
bool isOverflowClip = hasOverflowClip() && !layer()->isSelfPaintingLayer();
@@ -823,8 +823,6 @@ bool RenderBox::pushContentsClip(PaintInfo& paintInfo, const LayoutPoint& accumu
return false;
}
- if (paintInfo.phase == PaintPhaseOutline)
- paintInfo.phase = PaintPhaseChildOutlines;
paintInfo.context->save();
if (hasBorderRadius)
paintInfo.context->clipRoundedRect(clipRoundedRect);
@@ -835,13 +833,7 @@ bool RenderBox::pushContentsClip(PaintInfo& paintInfo, const LayoutPoint& accumu
void RenderBox::popContentsClip(PaintInfo& paintInfo, PaintPhase originalPhase, const LayoutPoint& accumulatedOffset)
{
ASSERT(hasOverflowClip() && !layer()->isSelfPaintingLayer());
-
paintInfo.context->restore();
- if (originalPhase == PaintPhaseOutline) {
- paintInfo.phase = PaintPhaseSelfOutline;
- paintObject(paintInfo, accumulatedOffset);
- paintInfo.phase = originalPhase;
- }
}
LayoutRect RenderBox::overflowClipRect(const LayoutPoint& location)

Powered by Google App Engine
This is Rietveld 408576698