Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Side by Side Diff: sky/engine/core/rendering/RenderLayerClipper.h

Issue 878023002: Merge outline paint phases into the foreground phase. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 88
89 ClipRects* getClipRects(const ClipRectsContext&) const; 89 ClipRects* getClipRects(const ClipRectsContext&) const;
90 90
91 ClipRect backgroundClipRect(const ClipRectsContext&) const; 91 ClipRect backgroundClipRect(const ClipRectsContext&) const;
92 92
93 // This method figures out our layerBounds in coordinates relative to 93 // This method figures out our layerBounds in coordinates relative to
94 // |rootLayer|. It also computes our background and foreground clip rects 94 // |rootLayer|. It also computes our background and foreground clip rects
95 // for painting/event handling. 95 // for painting/event handling.
96 // Pass offsetFromRoot if known. 96 // Pass offsetFromRoot if known.
97 void calculateRects(const ClipRectsContext&, const LayoutRect& paintDirtyRec t, LayoutRect& layerBounds, 97 void calculateRects(const ClipRectsContext&, const LayoutRect& paintDirtyRec t, LayoutRect& layerBounds,
98 ClipRect& backgroundRect, ClipRect& foregroundRect, ClipRect& outlineRec t, const LayoutPoint* offsetFromRoot = 0) const; 98 ClipRect& backgroundRect, ClipRect& foregroundRect, const LayoutPoint* o ffsetFromRoot = 0) const;
99 99
100 private: 100 private:
101 void calculateClipRects(const ClipRectsContext&, ClipRects&) const; 101 void calculateClipRects(const ClipRectsContext&, ClipRects&) const;
102 102
103 ClipRects* clipRectsIfCached(const ClipRectsContext&) const; 103 ClipRects* clipRectsIfCached(const ClipRectsContext&) const;
104 ClipRects* storeClipRectsInCache(const ClipRectsContext&, ClipRects* parentC lipRects, const ClipRects&) const; 104 ClipRects* storeClipRectsInCache(const ClipRectsContext&, ClipRects* parentC lipRects, const ClipRects&) const;
105 105
106 // cachedClipRects looks buggy: It doesn't check whether context.rootLayer a nd entry.root match. 106 // cachedClipRects looks buggy: It doesn't check whether context.rootLayer a nd entry.root match.
107 // FIXME: Move callers to clipRectsIfCached, which does the proper checks. 107 // FIXME: Move callers to clipRectsIfCached, which does the proper checks.
108 ClipRects* cachedClipRects(const ClipRectsContext& context) const 108 ClipRects* cachedClipRects(const ClipRectsContext& context) const
(...skipping 13 matching lines...) Expand all
122 } 122 }
123 123
124 // FIXME: Could this be a RenderBox? 124 // FIXME: Could this be a RenderBox?
125 RenderLayerModelObject& m_renderer; 125 RenderLayerModelObject& m_renderer;
126 mutable OwnPtr<ClipRectsCache> m_cache; 126 mutable OwnPtr<ClipRectsCache> m_cache;
127 }; 127 };
128 128
129 } // namespace blink 129 } // namespace blink
130 130
131 #endif // SKY_ENGINE_CORE_RENDERING_RENDERLAYERCLIPPER_H_ 131 #endif // SKY_ENGINE_CORE_RENDERING_RENDERLAYERCLIPPER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698