net/android/network_change_notifier_delegate_android.cc - Issue 877993003: Pass FROM_HERE to ObserverListThreadSafe::Notify to improve profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/android/network_change_notifier_delegate_android.cc

Issue 877993003: Pass FROM_HERE to ObserverListThreadSafe::Notify to improve profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/android/network_change_notifier_delegate_android.cc

diff --git a/net/android/network_change_notifier_delegate_android.cc b/net/android/network_change_notifier_delegate_android.cc

index 99a6cc2d771432d3943726612d989e83b3f98f15..f623b14798528f5e2ea7cd811893b3fe5b8a867e 100644

--- a/net/android/network_change_notifier_delegate_android.cc

+++ b/net/android/network_change_notifier_delegate_android.cc

@@ -97,7 +97,7 @@ void NetworkChangeNotifierDelegateAndroid::NotifyConnectionTypeChanged(

const ConnectionType actual_connection_type = ConvertConnectionType(

new_connection_type);

SetCurrentConnectionType(actual_connection_type);

- observers_->Notify(&Observer::OnConnectionTypeChanged);

+ observers_->Notify(FROM_HERE, &Observer::OnConnectionTypeChanged);

}

jint NetworkChangeNotifierDelegateAndroid::GetConnectionType(JNIEnv*,

@@ -113,7 +113,8 @@ void NetworkChangeNotifierDelegateAndroid::NotifyMaxBandwidthChanged(

DCHECK(thread_checker_.CalledOnValidThread());

DCHECK(new_max_bandwidth != GetCurrentMaxBandwidth());

SetCurrentMaxBandwidth(new_max_bandwidth);

- observers_->Notify(&Observer::OnMaxBandwidthChanged, new_max_bandwidth);

+ observers_->Notify(FROM_HERE, &Observer::OnMaxBandwidthChanged,

+ new_max_bandwidth);

}

void NetworkChangeNotifierDelegateAndroid::AddObserver(

« no previous file with comments | « media/base/user_input_monitor_win.cc ('k') | net/base/network_change_notifier.cc » ('j') | no next file with comments »