extensions/browser/api/storage/storage_api.cc - Issue 877993003: Pass FROM_HERE to ObserverListThreadSafe::Notify to improve profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/storage/storage_api.cc

Issue 877993003: Pass FROM_HERE to ObserverListThreadSafe::Notify to improve profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/storage/storage_api.cc

diff --git a/extensions/browser/api/storage/storage_api.cc b/extensions/browser/api/storage/storage_api.cc

index 38c8e7181ac47b48fb7146eb5d3fb3a441aba76a..da02e87979fc830e656a9f5952bf2dc53f5f8534 100644

--- a/extensions/browser/api/storage/storage_api.cc

+++ b/extensions/browser/api/storage/storage_api.cc

@@ -88,11 +88,9 @@ ExtensionFunction::ResponseValue SettingsFunction::UseWriteResult(

return HandleError(result->error(), storage);

if (!result->changes().empty()) {

- observers_->Notify(

- &SettingsObserver::OnSettingsChanged,

- extension_id(),

- settings_namespace_,

- ValueStoreChange::ToJson(result->changes()));

+ observers_->Notify(FROM_HERE, &SettingsObserver::OnSettingsChanged,

+ extension_id(), settings_namespace_,

+ ValueStoreChange::ToJson(result->changes()));

}

return NoArguments();

« no previous file with comments | « content/renderer/p2p/socket_dispatcher.cc ('k') | media/base/user_input_monitor_linux.cc » ('j') | no next file with comments »