components/password_manager/core/browser/password_store.cc - Issue 877993003: Pass FROM_HERE to ObserverListThreadSafe::Notify to improve profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_store.cc

Issue 877993003: Pass FROM_HERE to ObserverListThreadSafe::Notify to improve profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/local/canned_syncable_file_system.cc ('k') | components/storage_monitor/storage_monitor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_store.cc

diff --git a/components/password_manager/core/browser/password_store.cc b/components/password_manager/core/browser/password_store.cc

index 164db45209728823677aea2364155392f17fb674..aa9cd82a7c027ee486263e0b7441ce7e3466adb9 100644

--- a/components/password_manager/core/browser/password_store.cc

+++ b/components/password_manager/core/browser/password_store.cc

@@ -241,7 +241,7 @@ void PasswordStore::NotifyLoginsChanged(

const PasswordStoreChangeList& changes) {

DCHECK(GetBackgroundTaskRunner()->BelongsToCurrentThread());

if (!changes.empty()) {

- observers_->Notify(&Observer::OnLoginsChanged, changes);

+ observers_->Notify(FROM_HERE, &Observer::OnLoginsChanged, changes);

#if defined(PASSWORD_MANAGER_ENABLE_SYNC)

if (syncable_service_)

syncable_service_->ActOnPasswordStoreChanges(changes);