chrome/browser/extensions/api/storage/syncable_settings_storage.cc - Issue 877993003: Pass FROM_HERE to ObserverListThreadSafe::Notify to improve profile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/storage/syncable_settings_storage.cc

Issue 877993003: Pass FROM_HERE to ObserverListThreadSafe::Notify to improve profile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/storage/policy_value_store.cc ('k') | chrome/browser/sync_file_system/local/canned_syncable_file_system.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/storage/syncable_settings_storage.cc

diff --git a/chrome/browser/extensions/api/storage/syncable_settings_storage.cc b/chrome/browser/extensions/api/storage/syncable_settings_storage.cc

index 95d95ec711e1975af16b427743315f8d3289652c..d25bd170c3ef1e61dd9bbf92d4c92c86d927c456 100644

--- a/chrome/browser/extensions/api/storage/syncable_settings_storage.cc

+++ b/chrome/browser/extensions/api/storage/syncable_settings_storage.cc

@@ -356,11 +356,9 @@ syncer::SyncError SyncableSettingsStorage::ProcessSyncChanges(

sync_processor_->NotifyChanges(changes);

- observers_->Notify(

- &SettingsObserver::OnSettingsChanged,

- extension_id_,

- settings_namespace::SYNC,

- ValueStoreChange::ToJson(changes));

+ observers_->Notify(FROM_HERE, &SettingsObserver::OnSettingsChanged,

+ extension_id_, settings_namespace::SYNC,

+ ValueStoreChange::ToJson(changes));

// TODO(kalman): Something sensible with multiple errors.

return errors.empty() ? syncer::SyncError() : errors[0];