Implement base.IPC

remoting/webapp/unittests/chrome_mocks.js

Index: remoting/webapp/unittests/chrome_mocks.js
diff --git a/remoting/webapp/unittests/chrome_mocks.js b/remoting/webapp/unittests/chrome_mocks.js
index 7a21da3c288d2bdf02d3e3056c7d8306a5972913..e7d9f93c3320d9b9bd3ceadb4ccf44e504380406 100644
--- a/remoting/webapp/unittests/chrome_mocks.js
+++ b/remoting/webapp/unittests/chrome_mocks.js
@@ -28,9 +28,10 @@ chromeMocks.Event.prototype.removeListener = function(callback) {
   }
 };
 
-chromeMocks.Event.prototype.mock$fire = function(data) {
+chromeMocks.Event.prototype.mock$fire = function(var_args) {
+  var params = Array.prototype.slice.call(arguments);
   this.listeners_.forEach(function(listener){
-    listener(data);
+    listener.apply(null, params);
   });
 };
 
@@ -47,6 +48,21 @@ chromeMocks.runtime.Port = function() {
 chromeMocks.runtime.Port.prototype.disconnect = function() {};
 chromeMocks.runtime.Port.prototype.postMessage = function() {};
 
+chromeMocks.runtime.onMessage = new chromeMocks.Event();
+chromeMocks.runtime.sendMessage = function(extensionId, message,
+                                           responseCallback) {
+  if (!extensionId) {

[Jamie, 2015/01/27 22:52:25]

This should not be conditional, I don't think. When calling mock$fire, the
extension id should be that of the sender, whereas when calling sendMessage it's
the id of the receiver. As I noted earlier, I think you should assert here that
extensionId is null, since I think that's the only value that makes sense for
testing (when testing communication with an external extension, you'd probably
need to write a custom mock anyway).

[kelvinp, 2015/01/28 01:31:51]

Done.

+    extensionId = chromeMocks.runtime.id;
+  }
+
+  window.requestAnimationFrame(function(){
+   chromeMocks.runtime.onMessage.mock$fire(message, {id: extensionId},

[Jamie, 2015/01/27 22:52:25]

Maybe convert |message| to JSON and back, since that better matches what the
real API does. For example, it would let you test code that either modifies
|message| before it is processed by the recipient or tries to include
non-serializable fields.

[kelvinp, 2015/01/28 01:31:51]

Good idea :) Done.

+                                           responseCallback);
+  });
+};
+
+chromeMocks.runtime.id = 'extensionId';
+
 chromeMocks.storage = {};
 
 // Sample implementation of chrome.StorageArea according to