Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: remoting/webapp/js_proto/chrome_proto.js

Issue 877993002: Implement base.IPC (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reviewer's feedback Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/js_proto/chrome_proto.js
diff --git a/remoting/webapp/js_proto/chrome_proto.js b/remoting/webapp/js_proto/chrome_proto.js
index c7de1ac2cba718c76e4c726d0f87b9e7223d1985..d47ef43da6c230371d82dfe8f1ae2cd05fd63f52 100644
--- a/remoting/webapp/js_proto/chrome_proto.js
+++ b/remoting/webapp/js_proto/chrome_proto.js
@@ -39,9 +39,9 @@ chrome.app.window = {
current: function() {},
/**
* @param {string} id
- * @param {function()=} opt_callback
+ * @return {AppWindow}
*/
- get: function(id, opt_callback) {},
+ get: function(id) {},
/**
* @return {Array.<AppWindow>}
*/
@@ -88,7 +88,7 @@ chrome.runtime.connectNative = function(name) {};
chrome.runtime.connect = function(config) {};
/**
- * @param {string} extensionId
+ * @param {string?} extensionId
* @param {*} message
* @param {Object=} opt_options
* @param {function(*)=} opt_callback
@@ -100,6 +100,10 @@ chrome.runtime.sendMessage = function(
chrome.runtime.MessageSender = function(){
/** @type {chrome.Tab} */
this.tab = null;
+ /** @type {string} */
+ this.id = '';
+ /** @type {string} */
+ this.url = '';
};
/** @constructor */

Powered by Google App Engine
This is Rietveld 408576698