Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 877943002: Roll src/breakpad/src 58aca2d:398c70a (svn 1413:1414) (Closed)

Created:
5 years, 11 months ago by erikchen
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll src/breakpad/src 58aca2d:398c70a (svn 1413:1414) Summary of changes available at: https://chromium.googlesource.com/external/google-breakpad/src/+log/58aca2d..398c70a 398c70a Fix a source of memory corruption. BUG=449214 Committed: https://crrev.com/a0ee424d3b0c1ffe2f86509b262fb5c3c18ade1a Cr-Commit-Position: refs/heads/master@{#313200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
erikchen
amineer: Please review.
5 years, 11 months ago (2015-01-26 23:43:32 UTC) #2
amineer_google
On 2015/01/26 23:43:32, erikchen wrote: > amineer: Please review. lgtm
5 years, 11 months ago (2015-01-26 23:45:38 UTC) #3
amineer
On 2015/01/26 23:45:38, amineer wrote: > On 2015/01/26 23:43:32, erikchen wrote: > > amineer: Please ...
5 years, 11 months ago (2015-01-26 23:46:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877943002/1
5 years, 11 months ago (2015-01-26 23:47:13 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-26 23:47:15 UTC) #8
erikchen
mark: Please review.
5 years, 11 months ago (2015-01-26 23:48:05 UTC) #10
Mark Mentovai
LGTM
5 years, 11 months ago (2015-01-27 00:03:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877943002/1
5 years, 11 months ago (2015-01-27 00:06:35 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-27 01:50:17 UTC) #14
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 01:51:33 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0ee424d3b0c1ffe2f86509b262fb5c3c18ade1a
Cr-Commit-Position: refs/heads/master@{#313200}

Powered by Google App Engine
This is Rietveld 408576698