cc/layers/scrollbar_layer_impl_base.cc - Issue 877863002: Hide pinch viewport scrollbars when near minimum scale.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/layers/scrollbar_layer_impl_base.cc

Issue 877863002: Hide pinch viewport scrollbars when near minimum scale. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Threshold multiplicative, prevent commit clobber of hide layer Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/layers/scrollbar_layer_impl_base.cc

diff --git a/cc/layers/scrollbar_layer_impl_base.cc b/cc/layers/scrollbar_layer_impl_base.cc

index beac79f6cca24c68dc17253f1193a6918f5998a2..35e716bdbd85463479813f80344acbb51162d866 100644

--- a/cc/layers/scrollbar_layer_impl_base.cc

+++ b/cc/layers/scrollbar_layer_impl_base.cc

@@ -33,8 +33,10 @@ ScrollbarLayerImplBase::~ScrollbarLayerImplBase() {}

void ScrollbarLayerImplBase::PushPropertiesTo(LayerImpl* layer) {

float active_opacity = layer->opacity();

+ bool active_hidden = layer->hide_layer_and_subtree();

LayerImpl::PushPropertiesTo(layer);

layer->SetOpacity(active_opacity);

+ layer->SetHideLayerAndSubtree(active_hidden);

DCHECK(layer->ToScrollbarLayer());

layer->ToScrollbarLayer()->set_is_overlay_scrollbar(is_overlay_scrollbar_);

PushScrollClipPropertiesTo(layer);

« no previous file with comments | « cc/layers/layer_impl.cc ('k') | cc/trees/layer_tree_impl.h » ('j') | cc/trees/layer_tree_impl_unittest.cc » ('J')