Collect stderr separately from stdout and append it to the layout test outp...

- Collect stderr separately from stdout and append it to the layout test output.
- Write #EOF to stderr at the end of each test so it doesn't block.
- Disable "DidStopLoading called while not loading" and "DidStartLoading called
while loading" errors temporarily so the ~165 tests that
give those errors can still be run while we fix the underlying problem.
- Update Windows test list accordingly.  stderr was always being included on
Mac, so these tests shouldn't have changed state there.

BUG=3937
TEST=covered by layout tests

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5183

[ojan, 2008-10-31 19:48:17]

Doesn't this mean the tests will fail on the debug builder?

[Pam (message me for reviews), 2008-10-31 19:59:50]

On 2008/10/31 19:48:17, ojan wrote:
> Doesn't this mean the tests will fail on the debug builder?

Oh, good catch.  I'd forgotten we were running them in debug again.  I'll
disable the LOG entirely rather than changing it to DLOG.

[ojan, 2008-10-31 20:37:32]

LGTM

[pink (ping after 24hrs), 2008-11-11 13:25:34]

LGTM with the Mac delegate fix.

http://codereview.chromium.org/8778/diff/22/26
File webkit/tools/test_shell/test_shell_win.cc (right):

http://codereview.chromium.org/8778/diff/22/26#newcode401
Line 401: fflush(stderr);
is it necessary to flush stderr? I thought it was unbuffered by nature.

http://codereview.chromium.org/8778/diff/22/25
File webkit/tools/test_shell/test_webview_delegate.cc (right):

http://codereview.chromium.org/8778/diff/22/25#newcode133
Line 133: //LOG(ERROR) << "DidStartLoading called while loading";
can you fix test_webview_delegate.mm as well?

[Pam (message me for reviews), 2008-11-11 18:04:47]

On 2008/11/11 13:25:34, pink wrote:
> LGTM with the Mac delegate fix.
> 
> http://codereview.chromium.org/8778/diff/22/26
> File webkit/tools/test_shell/test_shell_win.cc (right):
> 
> http://codereview.chromium.org/8778/diff/22/26#newcode401
> Line 401: fflush(stderr);
> is it necessary to flush stderr? I thought it was unbuffered by nature.

It's not necessary, but it won't hurt anything, and I prefer the parallelism.
I'm not adamant about that, though.

> http://codereview.chromium.org/8778/diff/22/25
> File webkit/tools/test_shell/test_webview_delegate.cc (right):
> 
> http://codereview.chromium.org/8778/diff/22/25#newcode133
> Line 133: //LOG(ERROR) << "DidStartLoading called while loading";
> can you fix test_webview_delegate.mm as well?

Done and committed. I see Linux hasn't ported this file.