Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 877783005: Fix a style issue: Add braces around a multi-line if statement. (Closed)

Created:
5 years, 11 months ago by eroman
Modified:
5 years, 11 months ago
Reviewers:
davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix a style issue: Add braces around a multi-line if statement. Also removes some now unreachable code following the BoringSSL roll. Committed: https://crrev.com/86177e68c78cd0a994a6ad483aa5e6ba8fcfd9a8 Cr-Commit-Position: refs/heads/master@{#313178}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address David's feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M content/child/webcrypto/openssl/pbkdf2_openssl.cc View 1 2 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
eroman
5 years, 11 months ago (2015-01-26 22:55:25 UTC) #2
davidben
lgtm
5 years, 11 months ago (2015-01-26 22:56:26 UTC) #3
davidben
https://codereview.chromium.org/877783005/diff/1/content/child/webcrypto/openssl/pbkdf2_openssl.cc File content/child/webcrypto/openssl/pbkdf2_openssl.cc (right): https://codereview.chromium.org/877783005/diff/1/content/child/webcrypto/openssl/pbkdf2_openssl.cc#newcode89 content/child/webcrypto/openssl/pbkdf2_openssl.cc:89: base::CheckedNumeric<int> password_size = password.size(); We can probably get rid ...
5 years, 11 months ago (2015-01-26 22:57:23 UTC) #4
eroman
https://codereview.chromium.org/877783005/diff/1/content/child/webcrypto/openssl/pbkdf2_openssl.cc File content/child/webcrypto/openssl/pbkdf2_openssl.cc (right): https://codereview.chromium.org/877783005/diff/1/content/child/webcrypto/openssl/pbkdf2_openssl.cc#newcode89 content/child/webcrypto/openssl/pbkdf2_openssl.cc:89: base::CheckedNumeric<int> password_size = password.size(); On 2015/01/26 22:57:23, David Benjamin ...
5 years, 11 months ago (2015-01-26 23:06:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/877783005/20001
5 years, 11 months ago (2015-01-26 23:09:15 UTC) #7
eroman
For the record, you are correct. That changed rolled in as part of: https://chromium.googlesource.com/chromium/src/+/4664fe0d123f948bafa7b942717fc5847e61971c
5 years, 11 months ago (2015-01-26 23:09:47 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-27 00:33:57 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-27 00:35:21 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86177e68c78cd0a994a6ad483aa5e6ba8fcfd9a8
Cr-Commit-Position: refs/heads/master@{#313178}

Powered by Google App Engine
This is Rietveld 408576698