Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Unified Diff: tests/compiler/dart2js/source_map_d2js_validity_test.dart

Issue 877753008: Fix shift in source map positions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/source_map_d2js_validity_test.dart
diff --git a/tests/compiler/dart2js/source_map_d2js_validity_test.dart b/tests/compiler/dart2js/source_map_d2js_validity_test.dart
index 7fe690c43a120ed050d288c484cca550a5612ae7..e450b1dc92ee854d3f1b65fecb6b14eb5e07a70e 100644
--- a/tests/compiler/dart2js/source_map_d2js_validity_test.dart
+++ b/tests/compiler/dart2js/source_map_d2js_validity_test.dart
@@ -13,18 +13,22 @@ import 'package:compiler/compiler.dart';
import 'source_map_validator_helper.dart';
void main() {
+ String mainFile = 'tests/compiler/dart2js/source_map_validator_test_file.dart';
floitsch 2015/02/02 10:17:57 long line.
Johnni Winther 2015/02/02 10:49:26 Done.
asyncTest(() => createTempDir().then((Directory tmpDir) {
print(
'Compiling tests/compiler/dart2js/source_map_validator_test_file.dart');
Future<CompilationResult> result = entry.internalMain(
- ['tests/compiler/dart2js/source_map_validator_test_file.dart',
+ [mainFile,
'-o${tmpDir.path}/out.js',
'--library-root=sdk']);
return result.then((CompilationResult result) {
Compiler compiler = result.compiler;
Uri uri =
new Uri.file('${tmpDir.path}/out.js', windows: Platform.isWindows);
- validateSourceMap(uri, compiler);
+ validateSourceMap(uri,
+ mainUri: Uri.base.resolve(mainFile),
+ mainPosition: const Position(13, 1),
+ compiler: compiler);
print("Deleting '${tmpDir.path}'.");
tmpDir.deleteSync(recursive: true);

Powered by Google App Engine
This is Rietveld 408576698